mirror of
https://github.com/prasathmani/tinyfilemanager.git
synced 2026-04-26 10:55:56 +03:00
[GH-ISSUE #142] Duplicate file with "copy" not working #103
Labels
No labels
Feature
Feature
Is It Really an Issue?
Need More Info
Request
Security
bug
duplicate
enhancement
enhancement
help wanted
invalid
pull-request
question
suggestion
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tinyfilemanager#103
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @VincentVandalon on GitHub (Mar 17, 2019).
Original GitHub issue: https://github.com/prasathmani/tinyfilemanager/issues/142
It is currently not possible to duplicate a file: it is possible to copy a file to a new directory but an error is thrown if the file is copied to the same directory. There is no option for copying into the same directory with a new/modified file name.
By the way, thank you very much for creating this nice and convenient tool!
@prasathmani commented on GitHub (Mar 18, 2019):
Copy to same path is not allowed, because you're already there, if you want to create a backup of the file, use backup option in the edit.
@VincentVandalon commented on GitHub (Mar 19, 2019):
I implemented some code to also support duplicating a file (quite inline with the current approach of copying a file) for my own use which might be of interest for the project as well. See also pull request "Added duplicate functionality" #146 (note that I closed the first pull request and opened a new one because I noticed that you can also copy and therefore duplicate folders).
I agree that the same functionality can be achieved by using the backup functionality but most users won't look there and they probably expect duplicate next to copy.
@prasathmani commented on GitHub (Mar 20, 2019):
@VincentVandalon thank you for your contribution, let me check.
@johnwmail commented on GitHub (Mar 21, 2019):
Hi, why need the new duplicate button, instead of merge to copy?
Thanks.
@VincentVandalon commented on GitHub (Mar 21, 2019):
Merging with copy requires a more extensive rewrite of the code (the current GUI isn't very suitable for a combined copy/duplicate). It would even be nicer, but I did not have the time to do it that way.
@johnwmail commented on GitHub (Mar 21, 2019):
Hi, I mean like this, thanks.
dup.diff.txt
@VincentVandalon commented on GitHub (Mar 21, 2019):
Now I understand what you mean, that might work. I will play around and update the pull request asap
@VincentVandalon commented on GitHub (Mar 22, 2019):
I have updated the pull request to now include the merged functionality.