[GH-ISSUE #89] Share Link doesn't use your site domain #73

Closed
opened 2026-03-03 00:07:35 +03:00 by kerem · 3 comments
Owner

Originally created by @shdf2 on GitHub (Dec 31, 2025).
Original GitHub issue: https://github.com/binimum/tidal-ui/issues/89

Looks like when you want to share a link, the link is created with https://music.binimum.org and not your website domain.

Originally created by @shdf2 on GitHub (Dec 31, 2025). Original GitHub issue: https://github.com/binimum/tidal-ui/issues/89 Looks like when you want to share a link, the link is created with https://music.binimum.org and not your website domain.
kerem 2026-03-03 00:07:35 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@shdf2 commented on GitHub (Dec 31, 2025):

well, i guess the problem is here :
github.com/uimaxbai/tidal-ui@3295aba410/src/lib/components/ShareButton.svelte (L30)

The base url is hard coded. so we can fix the line with our website domain.

<!-- gh-comment-id:3703058597 --> @shdf2 commented on GitHub (Dec 31, 2025): well, i guess the problem is here : https://github.com/uimaxbai/tidal-ui/blob/3295aba4108ed0b88c51ddbc18b0e03eccd555a1/src/lib/components/ShareButton.svelte#L30 The base url is hard coded. so we can fix the line with our website domain.
Author
Owner

@shdf2 commented on GitHub (Dec 31, 2025):

Maybe the function can be replaced by this :
function getLongLink() { return /${type}/${id}; }

<!-- gh-comment-id:3703061892 --> @shdf2 commented on GitHub (Dec 31, 2025): Maybe the function can be replaced by this : `function getLongLink() { return `/${type}/${id}`; } `
Author
Owner

@binimum commented on GitHub (Jan 1, 2026):

I had issues regarding HTTP and HTTPS - but to be honest I was too lazy to switch based on it so I just hardcoded the domain. I’ll get it fixed sometime soon

<!-- gh-comment-id:3703541727 --> @binimum commented on GitHub (Jan 1, 2026): I had issues regarding HTTP and HTTPS - but to be honest I was too lazy to switch based on it so I just hardcoded the domain. I’ll get it fixed sometime soon
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/tidal-ui#73
No description provided.