mirror of
https://github.com/binimum/tidal-ui.git
synced 2026-04-26 12:25:48 +03:00
[GH-ISSUE #89] Share Link doesn't use your site domain #73
Labels
No labels
bug
duplicate
enhancement
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tidal-ui#73
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @shdf2 on GitHub (Dec 31, 2025).
Original GitHub issue: https://github.com/binimum/tidal-ui/issues/89
Looks like when you want to share a link, the link is created with https://music.binimum.org and not your website domain.
@shdf2 commented on GitHub (Dec 31, 2025):
well, i guess the problem is here :
github.com/uimaxbai/tidal-ui@3295aba410/src/lib/components/ShareButton.svelte (L30)The base url is hard coded. so we can fix the line with our website domain.
@shdf2 commented on GitHub (Dec 31, 2025):
Maybe the function can be replaced by this :
function getLongLink() { return/${type}/${id}; }@binimum commented on GitHub (Jan 1, 2026):
I had issues regarding HTTP and HTTPS - but to be honest I was too lazy to switch based on it so I just hardcoded the domain. I’ll get it fixed sometime soon