[PR #87] [MERGED] fix --version parsing #93

New issue

Closed

opened 2026-03-03 01:21:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:21:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cs01/termpair/pull/87
Author: @cs01
Created: 8/31/2021
Status: ✅ Merged
Merged: 8/31/2021
Merged by: @cs01

Base: master ← Head: cs01/fix-version-parsing

📝 Commits (4)

36f4dca fix --version parsing
13d342a fix duplicate function name; add vscode settings file
c73b589 ensure yarn install is run before building
7ad879a prune vscode dir from manifest

📊 Changes

10 files changed (+31 additions, -11 deletions)

View changed files

📝 .gitignore (+0 -1)
➕ .vscode/settings.json (+9 -0)
📝 CHANGELOG.md (+4 -0)
📝 MANIFEST.in (+1 -0)
📝 makefile (+3 -3)
📝 noxfile.py (+7 -0)
📝 termpair/constants.py (+1 -1)
📝 termpair/frontend_src/src/constants.ts (+1 -1)
📝 termpair/main.py (+1 -5)
📝 tests/test_e2e.py (+4 -0)

📄 Description

I have added an entry to CHANGELOG.md

Summary of changes

Fix version parsing
add unit test
Increment version
Add vscode settings file

Test plan

Tested by running

nox -s termpair -- --version
nox -s tests-3.9

fixes #86

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cs01/termpair/pull/87 **Author:** [@cs01](https://github.com/cs01) **Created:** 8/31/2021 **Status:** ✅ Merged **Merged:** 8/31/2021 **Merged by:** [@cs01](https://github.com/cs01) **Base:** `master` ← **Head:** `cs01/fix-version-parsing` --- ### 📝 Commits (4) - [`36f4dca`](https://github.com/cs01/termpair/commit/36f4dca19700f02a58a2555e8e37b4e684b6c73e) fix --version parsing - [`13d342a`](https://github.com/cs01/termpair/commit/13d342a34bdab68b1c530a8e24801909440c0edf) fix duplicate function name; add vscode settings file - [`c73b589`](https://github.com/cs01/termpair/commit/c73b589f2d39b00c637e26840b91ecc06bc664cb) ensure yarn install is run before building - [`7ad879a`](https://github.com/cs01/termpair/commit/7ad879a911915b234a8d08645de7016a0f09f8d5) prune vscode dir from manifest ### 📊 Changes **10 files changed** (+31 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+0 -1) ➕ `.vscode/settings.json` (+9 -0) 📝 `CHANGELOG.md` (+4 -0) 📝 `MANIFEST.in` (+1 -0) 📝 `makefile` (+3 -3) 📝 `noxfile.py` (+7 -0) 📝 `termpair/constants.py` (+1 -1) 📝 `termpair/frontend_src/src/constants.ts` (+1 -1) 📝 `termpair/main.py` (+1 -5) 📝 `tests/test_e2e.py` (+4 -0) </details> ### 📄 Description  * [x] I have added an entry to `CHANGELOG.md` ## Summary of changes * Fix version parsing * add unit test * Increment version * Add vscode settings file ## Test plan  Tested by running ``` nox -s termpair -- --version nox -s tests-3.9 ``` fixes #86 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>