[PR #67] [MERGED] add e2e test; improve server test #73

New issue

Closed

opened 2026-03-03 01:21:30 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:21:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cs01/termpair/pull/67
Author: @cs01
Created: 7/20/2021
Status: ✅ Merged
Merged: 7/20/2021
Merged by: @cs01

Base: master ← Head: cs01/add-e2e-tests

📝 Commits (9)

4319f09 add e2e test; improve server test
facb6ee update github workflow to build app (required in e2e test)
4a65f1f fix test errors
79abb37 remove top level job to build react app
776fe2e try no capture
0db6466 omit e2e test on ci
e97d85f it will definitely work this time
c10c271 this time
179938e no this one

📊 Changes

6 files changed (+118 additions, -24 deletions)

View changed files

📝 .github/workflows/tests.yml (+8 -15)
📝 README.md (+2 -2)
📝 noxfile.py (+8 -2)
➕ tests/test_e2e.py (+77 -0)
➖ tests/test_project.py (+0 -5)
➕ tests/test_server.py (+23 -0)

📄 Description

Summary of changes

Add more unit tests
Add end to end test that starts a server and a broadcast, and confirms the websocket connection is made
- Unfortunately on github CI we are not connected to a tty, so we can't test the broadcast function, but we can still test that the server runs. There might be a workaround for it but I am not going to add it now.

Test plan

Tested by running

 nox -s test-3.8

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cs01/termpair/pull/67 **Author:** [@cs01](https://github.com/cs01) **Created:** 7/20/2021 **Status:** ✅ Merged **Merged:** 7/20/2021 **Merged by:** [@cs01](https://github.com/cs01) **Base:** `master` ← **Head:** `cs01/add-e2e-tests` --- ### 📝 Commits (9) - [`4319f09`](https://github.com/cs01/termpair/commit/4319f0940acf490675b6e72a703afa66c8483300) add e2e test; improve server test - [`facb6ee`](https://github.com/cs01/termpair/commit/facb6ee9e11312c0c38afc42efaca107748a153a) update github workflow to build app (required in e2e test) - [`4a65f1f`](https://github.com/cs01/termpair/commit/4a65f1fa30fc47b0a67c09809fbfab5b79ff3f1a) fix test errors - [`79abb37`](https://github.com/cs01/termpair/commit/79abb370b074018204a173f8e06be8022d2e9daa) remove top level job to build react app - [`776fe2e`](https://github.com/cs01/termpair/commit/776fe2ededc45ded436fe7229ff4265077ac3552) try no capture - [`0db6466`](https://github.com/cs01/termpair/commit/0db646628c1b205a5ed6d38f6d998cc3486152dd) omit e2e test on ci - [`e97d85f`](https://github.com/cs01/termpair/commit/e97d85f2ef6265af150cd358131aa4df82cec52f) it will definitely work this time - [`c10c271`](https://github.com/cs01/termpair/commit/c10c271df181aafdb09a0c96e71a3b5d02d0aad4) this time - [`179938e`](https://github.com/cs01/termpair/commit/179938e8e22acf399ffc3ac8a759314c1d9d6a16) no this one ### 📊 Changes **6 files changed** (+118 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/tests.yml` (+8 -15) 📝 `README.md` (+2 -2) 📝 `noxfile.py` (+8 -2) ➕ `tests/test_e2e.py` (+77 -0) ➖ `tests/test_project.py` (+0 -5) ➕ `tests/test_server.py` (+23 -0) </details> ### 📄 Description  ## Summary of changes * Add more unit tests * Add end to end test that starts a server and a broadcast, and confirms the websocket connection is made * Unfortunately on github CI we are not connected to a tty, so we can't test the broadcast function, but we can still test that the server runs. There might be a workaround for it but I am not going to add it now. ## Test plan  Tested by running ``` nox -s test-3.8 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>