[PR #66] [MERGED] improve state management #71

New issue

Closed

opened 2026-03-03 01:21:30 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:21:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cs01/termpair/pull/66
Author: @cs01
Created: 7/19/2021
Status: ✅ Merged
Merged: 7/19/2021
Merged by: @cs01

Base: master ← Head: cs01/improve-state-management

📝 Commits (1)

611b5fe better state management

📊 Changes

3 files changed (+185 additions, -105 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 termpair/frontend_src/src/App.tsx (+121 -71)
📝 termpair/server.py (+63 -34)

📄 Description

I have added an entry to CHANGELOG.md

Summary of changes

Make termpair icon a link to the page hosting termpair
Add new terminal/website states and ensure they are all handled. This leads to better error messages, including around insecure contexts
Print errors in red
Rename some variables on the server
Fix bug where connected browsers aren't notified if terminal closes its websocket connection

Test plan

Tested by running

yarn build
nox -s server
# in new terminal
nox -s broadcast

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cs01/termpair/pull/66 **Author:** [@cs01](https://github.com/cs01) **Created:** 7/19/2021 **Status:** ✅ Merged **Merged:** 7/19/2021 **Merged by:** [@cs01](https://github.com/cs01) **Base:** `master` ← **Head:** `cs01/improve-state-management` --- ### 📝 Commits (1) - [`611b5fe`](https://github.com/cs01/termpair/commit/611b5fe5848dfb5a137abe84c19b66b181e67502) better state management ### 📊 Changes **3 files changed** (+185 additions, -105 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `termpair/frontend_src/src/App.tsx` (+121 -71) 📝 `termpair/server.py` (+63 -34) </details> ### 📄 Description  * [x] I have added an entry to `CHANGELOG.md` ## Summary of changes * Make termpair icon a link to the page hosting termpair * Add new terminal/website states and ensure they are all handled. This leads to better error messages, including around insecure contexts * Print errors in red * Rename some variables on the server * Fix bug where connected browsers aren't notified if terminal closes its websocket connection ## Test plan  Tested by running ``` yarn build nox -s server # in new terminal nox -s broadcast ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>