[PR #40] [MERGED] Ensure error message is printed to browser's terminal if site is not served in a secure context #58

New issue

Closed

opened 2026-03-03 01:21:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:21:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cs01/termpair/pull/40
Author: @cs01
Created: 6/2/2021
Status: ✅ Merged
Merged: 6/2/2021
Merged by: @cs01

Base: master ← Head: cs01/add-error-message-insecure-connection

📝 Commits (1)

0954270 Ensure error message is printed to browser's terminal if site is not served in a secure context

📊 Changes

3 files changed (+15 additions, -8 deletions)

View changed files

📝 CHANGELOG.md (+3 -0)
📝 termpair/frontend_src/src/App.js (+11 -7)
📝 termpair/main.py (+1 -1)

📄 Description

The logic to display the error message had a bug. This PR fixes the bug and prints a red message in the terminal if the browser is not running in a secure context where window.crypto is unavailable.See https://developer.mozilla.org/en-US/docs/Web/API/Window/crypto.

fixes #39

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cs01/termpair/pull/40 **Author:** [@cs01](https://github.com/cs01) **Created:** 6/2/2021 **Status:** ✅ Merged **Merged:** 6/2/2021 **Merged by:** [@cs01](https://github.com/cs01) **Base:** `master` ← **Head:** `cs01/add-error-message-insecure-connection` --- ### 📝 Commits (1) - [`0954270`](https://github.com/cs01/termpair/commit/0954270df6fd0e83d4ea4626313163f942e24cdd) Ensure error message is printed to browser's terminal if site is not served in a secure context ### 📊 Changes **3 files changed** (+15 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+3 -0) 📝 `termpair/frontend_src/src/App.js` (+11 -7) 📝 `termpair/main.py` (+1 -1) </details> ### 📄 Description The logic to display the error message had a bug. This PR fixes the bug and prints a red message in the terminal if the browser is not running in a secure context where `window.crypto` is unavailable.See https://developer.mozilla.org/en-US/docs/Web/API/Window/crypto. fixes #39 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>