[PR #42] [MERGED] always display port in connection instructions #56

New issue

Closed

opened 2026-03-03 01:21:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:21:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cs01/termpair/pull/42
Author: @cs01
Created: 6/2/2021
Status: ✅ Merged
Merged: 6/2/2021
Merged by: @cs01

Base: master ← Head: cs01/change-displayed-port

📝 Commits (1)

9442c78 always display port in connection instructions

📊 Changes

4 files changed (+14 additions, -7 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 README.md (+3 -1)
📝 termpair/frontend_src/src/App.js (+9 -5)
📝 termpair/main.py (+1 -1)

📄 Description

Previously it was assumed if the port was not defined in window.location that it was running on port 80. However, if the protocol is https it is running on port 443, not port 80.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cs01/termpair/pull/42 **Author:** [@cs01](https://github.com/cs01) **Created:** 6/2/2021 **Status:** ✅ Merged **Merged:** 6/2/2021 **Merged by:** [@cs01](https://github.com/cs01) **Base:** `master` ← **Head:** `cs01/change-displayed-port` --- ### 📝 Commits (1) - [`9442c78`](https://github.com/cs01/termpair/commit/9442c78180799d18f944006873735ebaade3981c) always display port in connection instructions ### 📊 Changes **4 files changed** (+14 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `README.md` (+3 -1) 📝 `termpair/frontend_src/src/App.js` (+9 -5) 📝 `termpair/main.py` (+1 -1) </details> ### 📄 Description Previously it was assumed if the port was not defined in `window.location` that it was running on port 80. However, if the protocol is `https` it is running on port 443, not port 80. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>