[GH-ISSUE #165] Container might not need to calculate area size upon construction #97

New issue

Closed

opened 2026-03-03 16:22:20 +03:00 by kerem · 1 comment

kerem commented

2026-03-03 16:22:20 +03:00

Owner

Originally created by @mum4k on GitHub (Mar 3, 2019).
Original GitHub issue: https://github.com/mum4k/termdash/issues/165

Originally assigned to: @mum4k on GitHub.

When the container is created, it pre-calculates areas for the root:

github.com/mum4k/termdash@275d95ad41/container/container.go (L79)

And for any children:
github.com/mum4k/termdash@275d95ad41/container/container.go (L164)
github.com/mum4k/termdash@275d95ad41/container/container.go (L174)

This is likely redundant, since the first time Draw() is called, the areas are recalculated again.
github.com/mum4k/termdash@275d95ad41/container/draw.go (L36)
github.com/mum4k/termdash@275d95ad41/container/draw.go (L44-L48)

If that is so, this should be removed and just set to image.ZR at initialization to avoid any confusion.

Originally created by @mum4k on GitHub (Mar 3, 2019). Original GitHub issue: https://github.com/mum4k/termdash/issues/165 Originally assigned to: @mum4k on GitHub. When the container is created, it pre-calculates areas for the root: https://github.com/mum4k/termdash/blob/275d95ad418b6ecca8817de4b013b440fc9abbe6/container/container.go#L79 And for any children: https://github.com/mum4k/termdash/blob/275d95ad418b6ecca8817de4b013b440fc9abbe6/container/container.go#L164 https://github.com/mum4k/termdash/blob/275d95ad418b6ecca8817de4b013b440fc9abbe6/container/container.go#L174 This is likely redundant, since the first time Draw() is called, the areas are recalculated again. https://github.com/mum4k/termdash/blob/275d95ad418b6ecca8817de4b013b440fc9abbe6/container/draw.go#L36 https://github.com/mum4k/termdash/blob/275d95ad418b6ecca8817de4b013b440fc9abbe6/container/draw.go#L44-L48 If that is so, this should be removed and just set to image.ZR at initialization to avoid any confusion.