starred/termdash

Fork 0

mirror of https://github.com/mum4k/termdash.git synced 2026-04-27 03:15:55 +03:00

[GH-ISSUE #81] Implement support for other line styles #55

New issue

Closed

opened 2026-03-03 16:21:59 +03:00 by kerem · 9 comments

kerem commented

2026-03-03 16:21:59 +03:00

Owner

Originally created by @mum4k on GitHub (Jan 19, 2019).
Original GitHub issue: https://github.com/mum4k/termdash/issues/81

Currently only one line style is supported:

https://github.com/mum4k/termdash/blob/master/draw/line_style.go

Originally created by @mum4k on GitHub (Jan 19, 2019). Original GitHub issue: https://github.com/mum4k/termdash/issues/81 Currently only one line style is supported: https://github.com/mum4k/termdash/blob/master/draw/line_style.go

kerem

2026-03-03 16:21:59 +03:00

closed this issue
added the
enhancement

good first issue

help wanted
labels

kerem commented

2026-03-03 16:22:00 +03:00

Author

Owner

@nilathedragon commented on GitHub (Jan 23, 2019):

I've implemented a LineStyleDouble which looks like this:

@nilathedragon commented on GitHub (Jan 23, 2019): I've implemented a LineStyleDouble which looks like this: <img width="1662" alt="image" src="https://user-images.githubusercontent.com/43315617/51633224-73601700-1f51-11e9-8150-ed90feeb3ce6.png">

kerem commented

2026-03-03 16:22:00 +03:00

Author

Owner

@nilathedragon commented on GitHub (Jan 23, 2019):

I'll open a pull-request as soon as I figured out how to not submit my commits from my other pull-request too...

Edit: Actually, I'll just submit them with the one I opened. I messed this up and should not have worked on the master of my fork. Lesson learned

@nilathedragon commented on GitHub (Jan 23, 2019): I'll open a pull-request as soon as I figured out how to not submit my commits from my other pull-request too... Edit: Actually, I'll just submit them with the one I opened. I messed this up and should not have worked on the master of my fork. Lesson learned

kerem commented

2026-03-03 16:22:01 +03:00

Author

Owner

@mum4k commented on GitHub (Jan 23, 2019):

To send this as a separate PR, I recommend creating a new fork off the devel branch, making the changes and sending a PR against it.

Let me know if you would like to get more details on this.

@mum4k commented on GitHub (Jan 23, 2019): To send this as a separate PR, I recommend creating a new fork off the devel branch, making the changes and sending a PR against it. Let me know if you would like to get more details on this.

kerem commented

2026-03-03 16:22:01 +03:00

Author

Owner

@mum4k commented on GitHub (Jan 25, 2019):

I wonder what you think - are there any other line styles worth adding or do we close this issue ?

@mum4k commented on GitHub (Jan 25, 2019): I wonder what you think - are there any other line styles worth adding or do we close this issue ?

kerem commented

2026-03-03 16:22:01 +03:00

Author

Owner

@nilathedragon commented on GitHub (Jan 25, 2019):

I cant think of any made of ASCII characters (https://theasciicode.com.ar)

If we can use Unicode, I can think of one or two more... I'd have to test that out first though

@nilathedragon commented on GitHub (Jan 25, 2019): I cant think of any made of ASCII characters (https://theasciicode.com.ar) If we can use Unicode, I can think of one or two more... I'd have to test that out first though

kerem commented

2026-03-03 16:22:01 +03:00

Author

Owner

@nilathedragon commented on GitHub (Jan 25, 2019):

This would be my "LineStyleRound" proposal. A bit more modern than the default single-line approach by adding some curves.

@nilathedragon commented on GitHub (Jan 25, 2019): This would be my "LineStyleRound" proposal. A bit more modern than the default single-line approach by adding some curves. <img width="1680" alt="image" src="https://user-images.githubusercontent.com/43315617/51733833-f765ec00-2082-11e9-9dbb-944304a21c89.png">

kerem commented

2026-03-03 16:22:01 +03:00

Author

Owner

@mum4k commented on GitHub (Jan 26, 2019):

Looks great, thanks for adding both. We indeed can use unicode, but I think you already know that ;)

I will leave it up to you to close this issue, not sure if you are still working on other line styles.

@mum4k commented on GitHub (Jan 26, 2019): Looks great, thanks for adding both. We indeed can use unicode, but I think you already know that ;) I will leave it up to you to close this issue, not sure if you are still working on other line styles.

kerem commented

2026-03-03 16:22:01 +03:00

Author

Owner

@nilathedragon commented on GitHub (Jan 26, 2019):

Thank you! Currently I am out of ideas for new borders. I will file a pull request if I get more ideas.

@nilathedragon commented on GitHub (Jan 26, 2019): Thank you! Currently I am out of ideas for new borders. I will file a pull request if I get more ideas.

kerem commented

2026-03-03 16:22:01 +03:00

Author

Owner

@mum4k commented on GitHub (Jan 26, 2019):

Sounds good, let's close this for now, we can as well follow the YAGNI principle and add it only once we need it ;)

@mum4k commented on GitHub (Jan 26, 2019): Sounds good, let's close this for now, we can as well follow the YAGNI principle and add it only once we need it ;)

kerem referenced this issue

2026-03-03 16:22:11 +03:00

[GH-ISSUE #121] Support anchoring or lazy-resize of the Y axis #81

kerem referenced this issue

2026-03-03 16:23:20 +03:00

[PR #133] [MERGED] The LineChart widget now supports zooming the content #214