starred/termdash

Fork 0

mirror of https://github.com/mum4k/termdash.git synced 2026-04-27 03:15:55 +03:00

[GH-ISSUE #72] Support padding of containers #54

New issue

Closed

opened 2026-03-03 16:21:57 +03:00 by kerem · 5 comments

kerem commented

2026-03-03 16:21:57 +03:00

Owner

Originally created by @mum4k on GitHub (Jan 15, 2019).
Original GitHub issue: https://github.com/mum4k/termdash/issues/72

So widgets can have some space around themselves.

Probably a separate padding for top, bottom, left, right. These can be implemented as new container options:
https://github.com/mum4k/termdash/blob/master/container/options.go

The size of the padding should be supplied in relative terms, so that this behaves well with terminal resize. I.e. percentage of the containers width / height.

Originally created by @mum4k on GitHub (Jan 15, 2019). Original GitHub issue: https://github.com/mum4k/termdash/issues/72 So widgets can have some space around themselves. Probably a separate padding for top, bottom, left, right. These can be implemented as new container options: https://github.com/mum4k/termdash/blob/master/container/options.go The size of the padding should be supplied in relative terms, so that this behaves well with terminal resize. I.e. percentage of the containers width / height.

kerem

2026-03-03 16:21:57 +03:00

closed this issue
added the
enhancement
label

kerem commented

2026-03-03 16:21:58 +03:00

Author

Owner

@nilathedragon commented on GitHub (Jan 25, 2019):

I've started experimenting with this.

Currently implemented are 4 new options:


// Adds 1 space of padding on the left
container.PaddingLeft(1)

// Adds 1 space of padding on the top
container.PaddingTop(1)

// Adds 1 space of padding on the right
container.PaddingRight(1)

// Adds 1 space of padding on the bottom
container.PaddingBottom(1)

On the testing part I might need some help. Currently not tested (Except for human testing)

Please see pull request #91 for code reviewing

@nilathedragon commented on GitHub (Jan 25, 2019): I've started experimenting with this. Currently implemented are 4 new options: ```go // Adds 1 space of padding on the left container.PaddingLeft(1) // Adds 1 space of padding on the top container.PaddingTop(1) // Adds 1 space of padding on the right container.PaddingRight(1) // Adds 1 space of padding on the bottom container.PaddingBottom(1) ``` On the testing part I might need some help. Currently not tested (Except for human testing) Please see pull request #91 for code reviewing

kerem commented

2026-03-03 16:21:58 +03:00

Author

Owner

@nilathedragon commented on GitHub (Jan 25, 2019):

Alright, I added a test which tests all 4 padding methods

@nilathedragon commented on GitHub (Jan 25, 2019): Alright, I added a test which tests all 4 padding methods

kerem commented

2026-03-03 16:21:59 +03:00

Author

Owner

@mum4k commented on GitHub (Jan 26, 2019):

Great, will respond on the PR shortly.

What do you think - should we also implement a margin for containers (i.e. a cleared area on the outside of the container)? If you think that's useful, we can file a separate issue and get to that separately / at a later time.

@mum4k commented on GitHub (Jan 26, 2019): Great, will respond on the PR shortly. What do you think - should we also implement a margin for containers (i.e. a cleared area on the outside of the container)? If you think that's useful, we can file a separate issue and get to that separately / at a later time.

kerem commented

2026-03-03 16:21:59 +03:00

Author

Owner

@nilathedragon commented on GitHub (Jan 26, 2019):

I think a margin sounds good. Will look at the coding part asap.

@nilathedragon commented on GitHub (Jan 26, 2019): I think a margin sounds good. Will look at the coding part asap.

kerem commented

2026-03-03 16:21:59 +03:00

Author

Owner

@mum4k commented on GitHub (Jan 26, 2019):

Thank you, I have filed #93 to track the margin feature. If you will be looking at that too, please send it in a separate PR.

@mum4k commented on GitHub (Jan 26, 2019): Thank you, I have filed #93 to track the margin feature. If you will be looking at that too, please send it in a separate PR.