[GH-ISSUE #63] There is a potential race between Options() and Draw() calls #46

New issue

Closed

opened 2026-03-03 16:21:55 +03:00 by kerem · 3 comments

kerem commented

2026-03-03 16:21:55 +03:00

Owner

Originally created by @mum4k on GitHub (Jan 13, 2019).
Original GitHub issue: https://github.com/mum4k/termdash/issues/63

This affects widgets that calculate their minimum size based on what data they currently have.

The following causes a race:

infra calls Options()
user changes values in the widget
infra calls Draw(), potentially not respecting the min size.

Originally created by @mum4k on GitHub (Jan 13, 2019). Original GitHub issue: https://github.com/mum4k/termdash/issues/63 This affects widgets that calculate their minimum size based on what data they currently have. The following causes a race: 1. infra calls Options() 1. user changes values in the widget 1. infra calls Draw(), potentially not respecting the min size.

kerem

2026-03-03 16:21:55 +03:00

closed this issue
added the
bug
label

kerem commented

2026-03-03 16:21:56 +03:00

Author

Owner

@activeshadow commented on GitHub (Jan 25, 2019):

Is this maybe the reason why a line chart with a min value > 0 still results in the Y Axis still being drawn all the way down to zero? I have a series that is in the range of 1600 - 1800, and my Y Axis is always from 0 to max instead of min to max.

@activeshadow commented on GitHub (Jan 25, 2019): Is this maybe the reason why a line chart with a min value > 0 still results in the Y Axis still being drawn all the way down to zero? I have a series that is in the range of 1600 - 1800, and my Y Axis is always from 0 to max instead of min to max.

kerem commented

2026-03-03 16:21:56 +03:00

Author

Owner

@mum4k commented on GitHub (Jan 25, 2019):

That looks unrelated, this is a bug that would trigger an error when a terminal resize event happens at a particular time between getting the widget's options and drawing the widget.

What you are describing is actually a design choice I made, quite possibly because I didn't understand all the use cases. Would you mind filing a separate issue where we can discuss the use case? Once we are on the same page, we can add a new feature to the LineChart so that the Y axis isn't always zero based.

@mum4k commented on GitHub (Jan 25, 2019): That looks unrelated, this is a bug that would trigger an error when a terminal resize event happens at a particular time between getting the widget's options and drawing the widget. What you are describing is actually a design choice I made, quite possibly because I didn't understand all the use cases. Would you mind filing a separate issue where we can discuss the use case? Once we are on the same page, we can add a new feature to the LineChart so that the Y axis isn't always zero based.

kerem commented

2026-03-03 16:21:56 +03:00

Author

Owner

@mum4k commented on GitHub (Jan 26, 2019):

@activeshadow fyi I had some time to test this and filed #92.

@mum4k commented on GitHub (Jan 26, 2019): @activeshadow fyi I had some time to test this and filed #92.

kerem referenced this issue

2026-03-03 16:23:09 +03:00

[PR #56] [MERGED] Function that draws horizontal and vertical lines. #176