mirror of
https://github.com/mum4k/termdash.git
synced 2026-04-27 03:15:55 +03:00
[PR #380] [MERGED] Adding Treeview Widget #373
Labels
No labels
bug
cleanup
enhancement
enhancement
enhancement
good first issue
help wanted
help wanted
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/termdash#373
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/mum4k/termdash/pull/380
Author: @keithknott26
Created: 9/16/2024
Status: ✅ Merged
Merged: 9/24/2024
Merged by: @mum4k
Base:
devel← Head:treeview📝 Commits (9)
102df20Merge pull request #374 from mum4k/release-0-20-0dd09e58Adding Treeview widget and testsf7d865aUpdated testing errors to pass724bebfUpdated treeview and tests to guard against race conditions2c8f554Updated tests and treeview with mutex lockingcd6f571Minor fixes for linting errorsd9ab04aAdded missing comments to types, added more tests, changed node to tv, changed Treeview to TreeViewd113610Added animated gif and updated README25bcdeaAdded suimon since it went missing in a previous commit📊 Changes
6 files changed (+1841 additions, -2 deletions)
View changed files
📝
README.md(+13 -2)➕
doc/images/treeviewdemo.gif(+0 -0)➕
widgets/treeview/options.go(+128 -0)➕
widgets/treeview/treeview.go(+780 -0)➕
widgets/treeview/treeview_test.go(+571 -0)➕
widgets/treeview/treeviewdemo/treeviewdemo.go(+349 -0)📄 Description
Hello Jakob,
Thanks for your hard work on this project, I often think about ways I could use it in my development efforts. Anyway, I've added a Treeview widget, demo, and tests to a fork of your repo under keithknott26/termdash. I felt I should contribute something hopefully useful to this effort.
Let me know if you'd like me to make any changes, the test coverage is not ideal given I wasn't too familiar with writing them for a UI type application. Mutex locks are in place so there are currently no race conditions as far as I know. Mouse and keyboard integration are included.
Cheers,
Keith Knott
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.