[PR #380] [MERGED] Adding Treeview Widget #373

Closed
opened 2026-03-03 16:24:07 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/mum4k/termdash/pull/380
Author: @keithknott26
Created: 9/16/2024
Status: Merged
Merged: 9/24/2024
Merged by: @mum4k

Base: develHead: treeview


📝 Commits (9)

  • 102df20 Merge pull request #374 from mum4k/release-0-20-0
  • dd09e58 Adding Treeview widget and tests
  • f7d865a Updated testing errors to pass
  • 724bebf Updated treeview and tests to guard against race conditions
  • 2c8f554 Updated tests and treeview with mutex locking
  • cd6f571 Minor fixes for linting errors
  • d9ab04a Added missing comments to types, added more tests, changed node to tv, changed Treeview to TreeView
  • d113610 Added animated gif and updated README
  • 25bcdea Added suimon since it went missing in a previous commit

📊 Changes

6 files changed (+1841 additions, -2 deletions)

View changed files

📝 README.md (+13 -2)
doc/images/treeviewdemo.gif (+0 -0)
widgets/treeview/options.go (+128 -0)
widgets/treeview/treeview.go (+780 -0)
widgets/treeview/treeview_test.go (+571 -0)
widgets/treeview/treeviewdemo/treeviewdemo.go (+349 -0)

📄 Description

Hello Jakob,

Thanks for your hard work on this project, I often think about ways I could use it in my development efforts. Anyway, I've added a Treeview widget, demo, and tests to a fork of your repo under keithknott26/termdash. I felt I should contribute something hopefully useful to this effort.

Let me know if you'd like me to make any changes, the test coverage is not ideal given I wasn't too familiar with writing them for a UI type application. Mutex locks are in place so there are currently no race conditions as far as I know. Mouse and keyboard integration are included.

Cheers,
Keith Knott


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mum4k/termdash/pull/380 **Author:** [@keithknott26](https://github.com/keithknott26) **Created:** 9/16/2024 **Status:** ✅ Merged **Merged:** 9/24/2024 **Merged by:** [@mum4k](https://github.com/mum4k) **Base:** `devel` ← **Head:** `treeview` --- ### 📝 Commits (9) - [`102df20`](https://github.com/mum4k/termdash/commit/102df20a882547528c83047688595acd2a82c7ef) Merge pull request #374 from mum4k/release-0-20-0 - [`dd09e58`](https://github.com/mum4k/termdash/commit/dd09e58d5cd6328b06583e979d7c7fcea926c65e) Adding Treeview widget and tests - [`f7d865a`](https://github.com/mum4k/termdash/commit/f7d865a2863affe73e49724c38494232b686c2ae) Updated testing errors to pass - [`724bebf`](https://github.com/mum4k/termdash/commit/724bebfde8259f1f08db0e7b3455d7d61e7b293e) Updated treeview and tests to guard against race conditions - [`2c8f554`](https://github.com/mum4k/termdash/commit/2c8f5540315da3bf208c9a3f6a5907b28ff3bc2b) Updated tests and treeview with mutex locking - [`cd6f571`](https://github.com/mum4k/termdash/commit/cd6f571a1b283f46aa9c89efe38aa9506cf9bdea) Minor fixes for linting errors - [`d9ab04a`](https://github.com/mum4k/termdash/commit/d9ab04a88badc3c2352e3d0335f079856f572168) Added missing comments to types, added more tests, changed node to tv, changed Treeview to TreeView - [`d113610`](https://github.com/mum4k/termdash/commit/d1136108c806075ec52f75db51e8dc83d01f973a) Added animated gif and updated README - [`25bcdea`](https://github.com/mum4k/termdash/commit/25bcdeadc205a6f8916816bb6b5e28fcd67240d9) Added suimon since it went missing in a previous commit ### 📊 Changes **6 files changed** (+1841 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+13 -2) ➕ `doc/images/treeviewdemo.gif` (+0 -0) ➕ `widgets/treeview/options.go` (+128 -0) ➕ `widgets/treeview/treeview.go` (+780 -0) ➕ `widgets/treeview/treeview_test.go` (+571 -0) ➕ `widgets/treeview/treeviewdemo/treeviewdemo.go` (+349 -0) </details> ### 📄 Description Hello Jakob, Thanks for your hard work on this project, I often think about ways I could use it in my development efforts. Anyway, I've added a Treeview widget, demo, and tests to a fork of your repo under keithknott26/termdash. I felt I should contribute something hopefully useful to this effort. Let me know if you'd like me to make any changes, the test coverage is not ideal given I wasn't too familiar with writing them for a UI type application. Mutex locks are in place so there are currently no race conditions as far as I know. Mouse and keyboard integration are included. Cheers, Keith Knott --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 16:24:07 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/termdash#373
No description provided.