[PR #260] [MERGED] Upgrade tcell to v2.x #286

New issue

Closed

opened 2026-03-03 16:23:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:23:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mum4k/termdash/pull/260
Author: @dyc3
Created: 11/14/2020
Status: ✅ Merged
Merged: 11/16/2020
Merged by: @mum4k

Base: devel ← Head: tcell-2.x-upgrade

📝 Commits (8)

4d320e3 upgrade tcell to v2.x
503c0ad Fixing color setting for tcell.
b4d53c1 Removing commented-out code.
0efc4a2 Updating CHANGELOG.
41375b8 Translating colors for backward compatibility with termbox-go.
685c0af Merge pull request #1 from mum4k/dyc3-tcell-2.x-upgrade-color-fix
66d9d49 explicitly name import "tcell"
0256bf1 fix typo in changelog

📊 Changes

12 files changed (+339 additions, -142 deletions)

View changed files

📝 CHANGELOG.md (+6 -2)
📝 cell/color.go (+21 -4)
📝 go.mod (+1 -1)
📝 go.sum (+2 -0)
📝 terminal/tcell/cell_options.go (+23 -17)
📝 terminal/tcell/cell_options_test.go (+262 -109)
📝 terminal/tcell/event.go (+1 -1)
📝 terminal/tcell/event_test.go (+1 -1)
📝 terminal/tcell/tcell.go (+2 -2)
📝 terminal/tcell/tcell_test.go (+1 -1)
📝 terminal/termbox/cell_options.go (+16 -1)
📝 terminal/terminalapi/color_mode.go (+3 -3)

📄 Description

A draft PR to close #254

I'll push stuff here as I get stuff working.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mum4k/termdash/pull/260 **Author:** [@dyc3](https://github.com/dyc3) **Created:** 11/14/2020 **Status:** ✅ Merged **Merged:** 11/16/2020 **Merged by:** [@mum4k](https://github.com/mum4k) **Base:** `devel` ← **Head:** `tcell-2.x-upgrade` --- ### 📝 Commits (8) - [`4d320e3`](https://github.com/mum4k/termdash/commit/4d320e3f2ea4b7a218dc1a3eb3e0abe664af135a) upgrade tcell to v2.x - [`503c0ad`](https://github.com/mum4k/termdash/commit/503c0ada52f554912be06f9d1853059175e6fb77) Fixing color setting for `tcell`. - [`b4d53c1`](https://github.com/mum4k/termdash/commit/b4d53c1f6caad4330907794b692881b7fef6caa0) Removing commented-out code. - [`0efc4a2`](https://github.com/mum4k/termdash/commit/0efc4a21a30a5f89db81b2af5682aa5640977172) Updating CHANGELOG. - [`41375b8`](https://github.com/mum4k/termdash/commit/41375b89351a1963552d91cb19dc11af36580690) Translating colors for backward compatibility with termbox-go. - [`685c0af`](https://github.com/mum4k/termdash/commit/685c0af26f82aeddb66e96e9390d8993c552c1be) Merge pull request #1 from mum4k/dyc3-tcell-2.x-upgrade-color-fix - [`66d9d49`](https://github.com/mum4k/termdash/commit/66d9d498b256a4e932a064483eea665d151f0826) explicitly name import "tcell" - [`0256bf1`](https://github.com/mum4k/termdash/commit/0256bf1f22b40c034411792468d1b0cbda652cce) fix typo in changelog ### 📊 Changes **12 files changed** (+339 additions, -142 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+6 -2) 📝 `cell/color.go` (+21 -4) 📝 `go.mod` (+1 -1) 📝 `go.sum` (+2 -0) 📝 `terminal/tcell/cell_options.go` (+23 -17) 📝 `terminal/tcell/cell_options_test.go` (+262 -109) 📝 `terminal/tcell/event.go` (+1 -1) 📝 `terminal/tcell/event_test.go` (+1 -1) 📝 `terminal/tcell/tcell.go` (+2 -2) 📝 `terminal/tcell/tcell_test.go` (+1 -1) 📝 `terminal/termbox/cell_options.go` (+16 -1) 📝 `terminal/terminalapi/color_mode.go` (+3 -3) </details> ### 📄 Description A draft PR to close #254 I'll push stuff here as I get stuff working. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>