[PR #251] [MERGED] add font modifier cell options: bold, italic, underline. #277

New issue

Closed

opened 2026-03-03 16:23:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:23:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mum4k/termdash/pull/251
Author: @dyc3
Created: 11/12/2020
Status: ✅ Merged
Merged: 11/14/2020
Merged by: @mum4k

Base: devel ← Head: font-modifiers

📝 Commits (5)

fe3e973 Merge pull request #244 from mum4k/release-0-12-2
2a7dafa Adding gex to the list of projects using Termdash.
50310f4 add font modifier cell options: bold, italic, underline.
f501a14 have the termbox backend return an error when attempting to use italics or strikethrough
53530e7 add tests for font modifier cell options

📊 Changes

10 files changed (+123 additions, -10 deletions)

View changed files

📝 README.md (+1 -0)
📝 cell/cell.go (+34 -2)
📝 go.mod (+1 -1)
📝 go.sum (+5 -0)
📝 terminal/tcell/cell_options.go (+2 -1)
📝 terminal/tcell/cell_options_test.go (+15 -0)
📝 terminal/termbox/cell_options.go (+20 -2)
📝 terminal/termbox/cell_options_test.go (+23 -0)
📝 terminal/termbox/termbox.go (+10 -2)
📝 widgets/text/textdemo/textdemo.go (+12 -2)

📄 Description

This PR adds cell options for the font modifiers bold, italic, and underline.

tcell was upgraded 1.4.0.

Strikethrough cell option was added as a no-op until tcell is updated to v2.0.0. I figured it wasn't a good idea to upgrade tcell by a whole major version without testing.

Closes #251

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mum4k/termdash/pull/251 **Author:** [@dyc3](https://github.com/dyc3) **Created:** 11/12/2020 **Status:** ✅ Merged **Merged:** 11/14/2020 **Merged by:** [@mum4k](https://github.com/mum4k) **Base:** `devel` ← **Head:** `font-modifiers` --- ### 📝 Commits (5) - [`fe3e973`](https://github.com/mum4k/termdash/commit/fe3e973531917978dd6d412520528bf10e092087) Merge pull request #244 from mum4k/release-0-12-2 - [`2a7dafa`](https://github.com/mum4k/termdash/commit/2a7dafa3a835dbe45d9a6eaa2f22e184666c8065) Adding `gex` to the list of projects using Termdash. - [`50310f4`](https://github.com/mum4k/termdash/commit/50310f4d29e7e7164a97b70a10c3d8e7ab837cbf) add font modifier cell options: bold, italic, underline. - [`f501a14`](https://github.com/mum4k/termdash/commit/f501a14afa3b9e2acd0de8c2119952c16288aa2f) have the termbox backend return an error when attempting to use italics or strikethrough - [`53530e7`](https://github.com/mum4k/termdash/commit/53530e7dc16275321a16880410ec04d81d4e2f2e) add tests for font modifier cell options ### 📊 Changes **10 files changed** (+123 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -0) 📝 `cell/cell.go` (+34 -2) 📝 `go.mod` (+1 -1) 📝 `go.sum` (+5 -0) 📝 `terminal/tcell/cell_options.go` (+2 -1) 📝 `terminal/tcell/cell_options_test.go` (+15 -0) 📝 `terminal/termbox/cell_options.go` (+20 -2) 📝 `terminal/termbox/cell_options_test.go` (+23 -0) 📝 `terminal/termbox/termbox.go` (+10 -2) 📝 `widgets/text/textdemo/textdemo.go` (+12 -2) </details> ### 📄 Description This PR adds cell options for the font modifiers bold, italic, and underline. `tcell` was upgraded 1.4.0. Strikethrough cell option was added as a no-op until tcell is updated to v2.0.0. I figured it wasn't a good idea to upgrade tcell by a whole major version without testing. Closes #251 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>