[PR #209] [CLOSED] Added indicator widget (tests pending) #256

New issue

Closed

opened 2026-03-03 16:23:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:23:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mum4k/termdash/pull/209
Author: @keithknott26
Created: 5/19/2019
Status: ❌ Closed

Base: devel ← Head: indicator

📝 Commits (10+)

4446b15 Added indicator widget (tests pending)
409d326 Fixes to the indicator post-review
d0cfdc9 Add files via upload
f615c4b Add files via upload
1dc718b Added post-review changes
257685d Update to Off function
c593321 Merge devel
8db7294 Post-review changes for indicator (toggle/on/off)
4b05965 Update showing what the scaled indicator looks like
24e4cad Options changes to the indicator widget

📊 Changes

4 files changed (+555 additions, -0 deletions)

View changed files

➕ widgets/indicator/circle.go (+59 -0)
➕ widgets/indicator/indicator.go (+250 -0)
➕ widgets/indicator/indicatordemo/indicatordemo.go (+141 -0)
➕ widgets/indicator/options.go (+105 -0)

📄 Description

This PR Serves to add the indicator branch as well as add the basic indicator functionality. I'd appreciate your comments on whether or not this widget should draw the indicator in a different way. Currently its using a unicode character to designate on/off. Another idea might be to have a rectangle filled with a color representing on/off?

Please run the indicatordemo to see the functionality, it supports text labels underneath similar to the donut however I'm having difficulty getting the text to align properly on resize. It may be just that the container is resizing.

Fixes #216

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mum4k/termdash/pull/209 **Author:** [@keithknott26](https://github.com/keithknott26) **Created:** 5/19/2019 **Status:** ❌ Closed **Base:** `devel` ← **Head:** `indicator` --- ### 📝 Commits (10+) - [`4446b15`](https://github.com/mum4k/termdash/commit/4446b15714547344c97efe97972029001cbdf871) Added indicator widget (tests pending) - [`409d326`](https://github.com/mum4k/termdash/commit/409d3260a59491137238d06426559d8c6a7758a9) Fixes to the indicator post-review - [`d0cfdc9`](https://github.com/mum4k/termdash/commit/d0cfdc979c2705cc9b704e42a65abaf4d3a69ed2) Add files via upload - [`f615c4b`](https://github.com/mum4k/termdash/commit/f615c4b1486ac68fa97a32c810f05f5c7be5f31d) Add files via upload - [`1dc718b`](https://github.com/mum4k/termdash/commit/1dc718b135cfedb61cde3884eaaa3749476b8050) Added post-review changes - [`257685d`](https://github.com/mum4k/termdash/commit/257685d7bc5c4b5b409a234d6d9740998be24f99) Update to Off function - [`c593321`](https://github.com/mum4k/termdash/commit/c59332134cfa9972e3fc688797d30a8cffe0a550) Merge devel - [`8db7294`](https://github.com/mum4k/termdash/commit/8db7294a9a9d92d0fa1dfc8e27a0b45f142683e5) Post-review changes for indicator (toggle/on/off) - [`4b05965`](https://github.com/mum4k/termdash/commit/4b059657b5823e23de5a89dcd9f5ebf4c612b0ad) Update showing what the scaled indicator looks like - [`24e4cad`](https://github.com/mum4k/termdash/commit/24e4cad9951062bba219f4e3006fb34bb7bee1d3) Options changes to the indicator widget ### 📊 Changes **4 files changed** (+555 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `widgets/indicator/circle.go` (+59 -0) ➕ `widgets/indicator/indicator.go` (+250 -0) ➕ `widgets/indicator/indicatordemo/indicatordemo.go` (+141 -0) ➕ `widgets/indicator/options.go` (+105 -0) </details> ### 📄 Description This PR Serves to add the indicator branch as well as add the basic indicator functionality. I'd appreciate your comments on whether or not this widget should draw the indicator in a different way. Currently its using a unicode character to designate on/off. Another idea might be to have a rectangle filled with a color representing on/off? Please run the indicatordemo to see the functionality, it supports text labels underneath similar to the donut however I'm having difficulty getting the text to align properly on resize. It may be just that the container is resizing. Fixes #216 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>