[PR #198] [MERGED] Support displaying the dot character in SegmentDisplay. #249

New issue

Closed

opened 2026-03-03 16:23:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:23:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mum4k/termdash/pull/198
Author: @mum4k
Created: 4/29/2019
Status: ✅ Merged
Merged: 5/1/2019
Merged by: @mum4k

Base: devel ← Head: dot-display

📝 Commits (10+)

57b9e78 Refactoring sixteen.
27c830c Adding licences.
f81cb55 Skeleton of the dotseg package.
b8a6427 Functions that move areas up and down.
a591f95 Factoring out function that calculates segment size.
939f8fe A segment display that can show three dots.
6159007 The SegmentDisplay now uses dot segment for dots and colons.
6578c20 More test coverage.
f13f732 More test coverage for dotseg.
a8d038e Renaming align.go to alignfor.go.

📊 Changes

20 files changed (+1714 additions, -287 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 doc/images/segmentdisplaydemo.gif (+0 -0)
📝 internal/alignfor/alignfor.go (+0 -0)
📝 internal/alignfor/alignfor_test.go (+0 -0)
📝 internal/area/area.go (+32 -0)
📝 internal/area/area_test.go (+108 -0)
➕ internal/segdisp/dotseg/attributes.go (+117 -0)
➕ internal/segdisp/dotseg/attributes_test.go (+56 -0)
➕ internal/segdisp/dotseg/dotseg.go (+238 -0)
➕ internal/segdisp/dotseg/dotseg_test.go (+602 -0)
➕ internal/segdisp/dotseg/testdotseg/testdotseg.go (+37 -0)
➕ internal/segdisp/segdisp.go (+90 -0)
➕ internal/segdisp/segdisp_test.go (+170 -0)
📝 internal/segdisp/sixteen/attributes.go (+16 -31)
📝 internal/segdisp/sixteen/sixteen.go (+4 -53)
📝 internal/segdisp/sixteen/sixteen_test.go (+48 -103)
📝 widgets/segmentdisplay/segment_area.go (+3 -3)
📝 widgets/segmentdisplay/segmentdisplay.go (+38 -9)
📝 widgets/segmentdisplay/segmentdisplay_test.go (+153 -87)
📝 widgets/segmentdisplay/segmentdisplaydemo/segmentdisplaydemo.go (+1 -1)

📄 Description

Fixes #183

Steps:

Factor code common to multiple segment display types out of the sixteen package.
Create a new segment display type that can display a dot and a colon.
Update SegmentDisplay to use the new display type.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mum4k/termdash/pull/198 **Author:** [@mum4k](https://github.com/mum4k) **Created:** 4/29/2019 **Status:** ✅ Merged **Merged:** 5/1/2019 **Merged by:** [@mum4k](https://github.com/mum4k) **Base:** `devel` ← **Head:** `dot-display` --- ### 📝 Commits (10+) - [`57b9e78`](https://github.com/mum4k/termdash/commit/57b9e78dc8e1d6ac446ae3ac9adbab1016de6a60) Refactoring sixteen. - [`27c830c`](https://github.com/mum4k/termdash/commit/27c830cebf08e079b95a1ab3d58efde3800f4520) Adding licences. - [`f81cb55`](https://github.com/mum4k/termdash/commit/f81cb554b0e3997247a8ce1f1a46c270a20ff1c7) Skeleton of the dotseg package. - [`b8a6427`](https://github.com/mum4k/termdash/commit/b8a6427d4786f6e6219ee39b886caf4b51799665) Functions that move areas up and down. - [`a591f95`](https://github.com/mum4k/termdash/commit/a591f95d2949a0224143eeeebedd3ea3ea9fdc20) Factoring out function that calculates segment size. - [`939f8fe`](https://github.com/mum4k/termdash/commit/939f8fe1994a8516977a93b6a2c2705a2d2ffc21) A segment display that can show three dots. - [`6159007`](https://github.com/mum4k/termdash/commit/6159007466989207bce03d9686f5fb057663ae03) The SegmentDisplay now uses dot segment for dots and colons. - [`6578c20`](https://github.com/mum4k/termdash/commit/6578c20aeac7f77e0e556aa16f4cd7979fe41ff7) More test coverage. - [`f13f732`](https://github.com/mum4k/termdash/commit/f13f732a66700df00a832b3852d3fc125aa542c1) More test coverage for dotseg. - [`a8d038e`](https://github.com/mum4k/termdash/commit/a8d038e6e75f9da615efbe6faf3bbe03849e1bfb) Renaming align.go to alignfor.go. ### 📊 Changes **20 files changed** (+1714 additions, -287 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `doc/images/segmentdisplaydemo.gif` (+0 -0) 📝 `internal/alignfor/alignfor.go` (+0 -0) 📝 `internal/alignfor/alignfor_test.go` (+0 -0) 📝 `internal/area/area.go` (+32 -0) 📝 `internal/area/area_test.go` (+108 -0) ➕ `internal/segdisp/dotseg/attributes.go` (+117 -0) ➕ `internal/segdisp/dotseg/attributes_test.go` (+56 -0) ➕ `internal/segdisp/dotseg/dotseg.go` (+238 -0) ➕ `internal/segdisp/dotseg/dotseg_test.go` (+602 -0) ➕ `internal/segdisp/dotseg/testdotseg/testdotseg.go` (+37 -0) ➕ `internal/segdisp/segdisp.go` (+90 -0) ➕ `internal/segdisp/segdisp_test.go` (+170 -0) 📝 `internal/segdisp/sixteen/attributes.go` (+16 -31) 📝 `internal/segdisp/sixteen/sixteen.go` (+4 -53) 📝 `internal/segdisp/sixteen/sixteen_test.go` (+48 -103) 📝 `widgets/segmentdisplay/segment_area.go` (+3 -3) 📝 `widgets/segmentdisplay/segmentdisplay.go` (+38 -9) 📝 `widgets/segmentdisplay/segmentdisplay_test.go` (+153 -87) 📝 `widgets/segmentdisplay/segmentdisplaydemo/segmentdisplaydemo.go` (+1 -1) </details> ### 📄 Description Fixes #183 Steps: - [x] Factor code common to multiple segment display types out of the sixteen package. - [x] Create a new segment display type that can display a dot and a colon. - [x] Update SegmentDisplay to use the new display type. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>