[PR #175] [MERGED] Prevent external mutation of data passed into widgets. #235

New issue

Closed

opened 2026-03-03 16:23:27 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:23:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mum4k/termdash/pull/175
Author: @mum4k
Created: 3/21/2019
Status: ✅ Merged
Merged: 3/21/2019
Merged by: @mum4k

Base: devel ← Head: 174-prevent-mutation

📝 Commits (2)

68fb760 Prevent external mutation of data passed into widgets.
3587cb9 Improving test coverage for scale.

📊 Changes

10 files changed (+193 additions, -10 deletions)

View changed files

📝 CHANGELOG.md (+3 -0)
📝 widgets/barchart/barchart.go (+5 -2)
📝 widgets/barchart/barchart_test.go (+55 -0)
📝 widgets/barchart/options.go (+3 -1)
📝 widgets/linechart/internal/axes/scale.go (+5 -0)
📝 widgets/linechart/internal/axes/scale_test.go (+1 -0)
📝 widgets/linechart/linechart.go (+16 -7)
📝 widgets/linechart/linechart_test.go (+47 -0)
📝 widgets/segmentdisplay/segmentdisplay_test.go (+34 -0)
📝 widgets/sparkline/sparkline_test.go (+24 -0)

📄 Description

Also better logging for out of bounds errors in LineChart.

Fixes #174.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mum4k/termdash/pull/175 **Author:** [@mum4k](https://github.com/mum4k) **Created:** 3/21/2019 **Status:** ✅ Merged **Merged:** 3/21/2019 **Merged by:** [@mum4k](https://github.com/mum4k) **Base:** `devel` ← **Head:** `174-prevent-mutation` --- ### 📝 Commits (2) - [`68fb760`](https://github.com/mum4k/termdash/commit/68fb7606d91dd40a376f84bb2a71203fa1d51a24) Prevent external mutation of data passed into widgets. - [`3587cb9`](https://github.com/mum4k/termdash/commit/3587cb9d7664f0394b142ad3361269c0bd3451ec) Improving test coverage for scale. ### 📊 Changes **10 files changed** (+193 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+3 -0) 📝 `widgets/barchart/barchart.go` (+5 -2) 📝 `widgets/barchart/barchart_test.go` (+55 -0) 📝 `widgets/barchart/options.go` (+3 -1) 📝 `widgets/linechart/internal/axes/scale.go` (+5 -0) 📝 `widgets/linechart/internal/axes/scale_test.go` (+1 -0) 📝 `widgets/linechart/linechart.go` (+16 -7) 📝 `widgets/linechart/linechart_test.go` (+47 -0) 📝 `widgets/segmentdisplay/segmentdisplay_test.go` (+34 -0) 📝 `widgets/sparkline/sparkline_test.go` (+24 -0) </details> ### 📄 Description Also better logging for out of bounds errors in LineChart. Fixes #174. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>