[PR #154] [MERGED] Refactoring packages that contained a mix of internal and public types. #226

New issue

Closed

opened 2026-03-03 16:23:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:23:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mum4k/termdash/pull/154
Author: @mum4k
Created: 2/24/2019
Status: ✅ Merged
Merged: 2/24/2019
Merged by: @mum4k

Base: devel ← Head: internal-refactor

📝 Commits (5)

0938ae9 Refactoring internal functions from align to internal/alignfor.
984f372 Factoring private type buffer out of cell.
290944c Adding licences.
2b7bbf2 Adding tests for keyboard and mouse enums.
fb95437 Updating CHANGELOG.

📊 Changes

24 files changed (+1514 additions, -1191 deletions)

View changed files

📝 CHANGELOG.md (+24 -1)
📝 align/align.go (+0 -103)
📝 align/align_test.go (+38 -297)
📝 cell/cell.go (+8 -164)
📝 cell/cell_test.go (+7 -515)
📝 cell/color_test.go (+5 -1)
📝 container/container.go (+2 -2)
➕ internal/alignfor/align.go (+120 -0)
➕ internal/alignfor/align_test.go (+351 -0)
➕ internal/canvas/buffer/buffer.go (+169 -0)
➕ internal/canvas/buffer/buffer_test.go (+580 -0)
📝 internal/canvas/canvas.go (+5 -4)
📝 internal/canvas/canvas_test.go (+88 -87)
📝 internal/canvas/testcanvas/testcanvas.go (+2 -1)
📝 internal/draw/border.go (+2 -1)
📝 internal/faketerm/faketerm.go (+6 -5)
➕ keyboard/keyboard_test.go (+49 -0)
➕ mouse/mouse_test.go (+44 -0)
📝 widgets/barchart/barchart.go (+2 -1)
📝 widgets/button/button.go (+2 -1)

...and 4 more files

📄 Description

Affected packages:

align
cell

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mum4k/termdash/pull/154 **Author:** [@mum4k](https://github.com/mum4k) **Created:** 2/24/2019 **Status:** ✅ Merged **Merged:** 2/24/2019 **Merged by:** [@mum4k](https://github.com/mum4k) **Base:** `devel` ← **Head:** `internal-refactor` --- ### 📝 Commits (5) - [`0938ae9`](https://github.com/mum4k/termdash/commit/0938ae91d87519ededfa09ac5cbc003e8937f274) Refactoring internal functions from align to internal/alignfor. - [`984f372`](https://github.com/mum4k/termdash/commit/984f37245d11464c41feca666f2f3fb67db967a4) Factoring private type buffer out of cell. - [`290944c`](https://github.com/mum4k/termdash/commit/290944c42c0d5551c4d1188b23ce1e35fabc5395) Adding licences. - [`2b7bbf2`](https://github.com/mum4k/termdash/commit/2b7bbf2391a35a11d98a65c0f6741a58df943edf) Adding tests for keyboard and mouse enums. - [`fb95437`](https://github.com/mum4k/termdash/commit/fb95437256e959661e2d0d2ac75c0886667d88f1) Updating CHANGELOG. ### 📊 Changes **24 files changed** (+1514 additions, -1191 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+24 -1) 📝 `align/align.go` (+0 -103) 📝 `align/align_test.go` (+38 -297) 📝 `cell/cell.go` (+8 -164) 📝 `cell/cell_test.go` (+7 -515) 📝 `cell/color_test.go` (+5 -1) 📝 `container/container.go` (+2 -2) ➕ `internal/alignfor/align.go` (+120 -0) ➕ `internal/alignfor/align_test.go` (+351 -0) ➕ `internal/canvas/buffer/buffer.go` (+169 -0) ➕ `internal/canvas/buffer/buffer_test.go` (+580 -0) 📝 `internal/canvas/canvas.go` (+5 -4) 📝 `internal/canvas/canvas_test.go` (+88 -87) 📝 `internal/canvas/testcanvas/testcanvas.go` (+2 -1) 📝 `internal/draw/border.go` (+2 -1) 📝 `internal/faketerm/faketerm.go` (+6 -5) ➕ `keyboard/keyboard_test.go` (+49 -0) ➕ `mouse/mouse_test.go` (+44 -0) 📝 `widgets/barchart/barchart.go` (+2 -1) 📝 `widgets/button/button.go` (+2 -1) _...and 4 more files_ </details> ### 📄 Description Affected packages: - align - cell --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>