[PR #138] [MERGED] Fixing invalid zooming behaviors. #217

New issue

Closed

opened 2026-03-03 16:23:21 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:23:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mum4k/termdash/pull/138
Author: @mum4k
Created: 2/18/2019
Status: ✅ Merged
Merged: 2/19/2019
Merged by: @mum4k

Base: devel ← Head: fully-unzoom

📝 Commits (2)

38ec4a9 Fixing invalid zooming behaviors.
5b89dbc Undo the experiments in the LineChart demo.

📊 Changes

9 files changed (+487 additions, -123 deletions)

View changed files

📝 widgets/linechart/axes/axes.go (+5 -0)
📝 widgets/linechart/axes/axes_test.go (+2 -0)
📝 widgets/linechart/axes/scale.go (+5 -0)
📝 widgets/linechart/axes/scale_test.go (+1 -0)
📝 widgets/linechart/axes/value.go (+1 -1)
📝 widgets/linechart/linechart.go (+5 -3)
📝 widgets/linechart/linechart_test.go (+117 -0)
📝 widgets/linechart/zoom/zoom.go (+93 -65)
📝 widgets/linechart/zoom/zoom_test.go (+258 -54)

📄 Description

stay unzoomed when we hit the largest view.
correctly normalize zoom values when the base axis is in motion.
test coverage for the edge cases.
acquire mutex on mouse events.

Fixes #136

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mum4k/termdash/pull/138 **Author:** [@mum4k](https://github.com/mum4k) **Created:** 2/18/2019 **Status:** ✅ Merged **Merged:** 2/19/2019 **Merged by:** [@mum4k](https://github.com/mum4k) **Base:** `devel` ← **Head:** `fully-unzoom` --- ### 📝 Commits (2) - [`38ec4a9`](https://github.com/mum4k/termdash/commit/38ec4a9e1ba8563931d4428f452fe11a6afcc565) Fixing invalid zooming behaviors. - [`5b89dbc`](https://github.com/mum4k/termdash/commit/5b89dbc1a0aea5eb524b315aca4d7400ad32c6d8) Undo the experiments in the LineChart demo. ### 📊 Changes **9 files changed** (+487 additions, -123 deletions) <details> <summary>View changed files</summary> 📝 `widgets/linechart/axes/axes.go` (+5 -0) 📝 `widgets/linechart/axes/axes_test.go` (+2 -0) 📝 `widgets/linechart/axes/scale.go` (+5 -0) 📝 `widgets/linechart/axes/scale_test.go` (+1 -0) 📝 `widgets/linechart/axes/value.go` (+1 -1) 📝 `widgets/linechart/linechart.go` (+5 -3) 📝 `widgets/linechart/linechart_test.go` (+117 -0) 📝 `widgets/linechart/zoom/zoom.go` (+93 -65) 📝 `widgets/linechart/zoom/zoom_test.go` (+258 -54) </details> ### 📄 Description - stay unzoomed when we hit the largest view. - correctly normalize zoom values when the base axis is in motion. - test coverage for the edge cases. - acquire mutex on mouse events. Fixes #136 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>