[PR #126] [MERGED] Constructors of all widgets now return an error. #208

New issue

Closed

opened 2026-03-03 16:23:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:23:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mum4k/termdash/pull/126
Author: @mum4k
Created: 2/15/2019
Status: ✅ Merged
Merged: 2/15/2019
Merged by: @mum4k

Base: devel ← Head: constructor-error

📝 Commits (7)

2949a79 Constructor of BarChart now returns an error.
3e84662 Merge branch 'devel' into constructor-error
1ab50bc Finished changes for BarChart and updated CHNAGELOG.
a6f5d69 Constructor of Gauge now returns an error.
231db41 Constructor of SparkLine now returns an error.
2784a1c Constructor of Text now returns an error.
ca21035 Also listing LineChart in the CHANGELOG.

📊 Changes

18 files changed (+491 additions, -218 deletions)

View changed files

📝 CHANGELOG.md (+7 -2)
📝 termdashdemo/termdashdemo.go (+49 -17)
📝 widgets/barchart/barchart.go (+6 -3)
📝 widgets/barchart/barchart_test.go (+91 -43)
📝 widgets/barchart/barchartdemo/barchartdemo.go (+4 -1)
📝 widgets/barchart/options.go (+17 -2)
📝 widgets/gauge/gauge.go (+6 -2)
📝 widgets/gauge/gauge_test.go (+97 -75)
📝 widgets/gauge/gaugedemo/gaugedemo.go (+19 -4)
📝 widgets/gauge/options.go (+12 -2)
📝 widgets/sparkline/options.go (+15 -3)
📝 widgets/sparkline/sparkline.go (+6 -2)
📝 widgets/sparkline/sparkline_test.go (+66 -50)
📝 widgets/sparkline/sparklinedemo/sparklinedemo.go (+12 -3)
📝 widgets/text/options.go (+23 -0)
📝 widgets/text/text.go (+5 -2)
📝 widgets/text/text_test.go (+36 -2)
📝 widgets/text/textdemo/textdemo.go (+20 -5)

📄 Description

Fixes #111

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mum4k/termdash/pull/126 **Author:** [@mum4k](https://github.com/mum4k) **Created:** 2/15/2019 **Status:** ✅ Merged **Merged:** 2/15/2019 **Merged by:** [@mum4k](https://github.com/mum4k) **Base:** `devel` ← **Head:** `constructor-error` --- ### 📝 Commits (7) - [`2949a79`](https://github.com/mum4k/termdash/commit/2949a793578d56e7a5910c927f3b041a7514db36) Constructor of BarChart now returns an error. - [`3e84662`](https://github.com/mum4k/termdash/commit/3e8466282e747aa4fec6c688ba1aa23139912103) Merge branch 'devel' into constructor-error - [`1ab50bc`](https://github.com/mum4k/termdash/commit/1ab50bcefc7572c57eaa4057e742bfcb0c0766dc) Finished changes for BarChart and updated CHNAGELOG. - [`a6f5d69`](https://github.com/mum4k/termdash/commit/a6f5d695697a257d68db8b16a0ffb36c3fa6b421) Constructor of Gauge now returns an error. - [`231db41`](https://github.com/mum4k/termdash/commit/231db41590252ada52524f997f4f30be79747dd8) Constructor of SparkLine now returns an error. - [`2784a1c`](https://github.com/mum4k/termdash/commit/2784a1c7a0fd05ea1d2ed96d43d4c7ada6d65653) Constructor of Text now returns an error. - [`ca21035`](https://github.com/mum4k/termdash/commit/ca21035e75efda1c7373d2937464d394f30eceda) Also listing LineChart in the CHANGELOG. ### 📊 Changes **18 files changed** (+491 additions, -218 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+7 -2) 📝 `termdashdemo/termdashdemo.go` (+49 -17) 📝 `widgets/barchart/barchart.go` (+6 -3) 📝 `widgets/barchart/barchart_test.go` (+91 -43) 📝 `widgets/barchart/barchartdemo/barchartdemo.go` (+4 -1) 📝 `widgets/barchart/options.go` (+17 -2) 📝 `widgets/gauge/gauge.go` (+6 -2) 📝 `widgets/gauge/gauge_test.go` (+97 -75) 📝 `widgets/gauge/gaugedemo/gaugedemo.go` (+19 -4) 📝 `widgets/gauge/options.go` (+12 -2) 📝 `widgets/sparkline/options.go` (+15 -3) 📝 `widgets/sparkline/sparkline.go` (+6 -2) 📝 `widgets/sparkline/sparkline_test.go` (+66 -50) 📝 `widgets/sparkline/sparklinedemo/sparklinedemo.go` (+12 -3) 📝 `widgets/text/options.go` (+23 -0) 📝 `widgets/text/text.go` (+5 -2) 📝 `widgets/text/text_test.go` (+36 -2) 📝 `widgets/text/textdemo/textdemo.go` (+20 -5) </details> ### 📄 Description Fixes #111 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>