[PR #122] [MERGED] Linechart now supports vertical label orientation under the X axis. #206

New issue

Closed

opened 2026-03-03 16:23:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:23:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mum4k/termdash/pull/122
Author: @mum4k
Created: 2/14/2019
Status: ✅ Merged
Merged: 2/14/2019
Merged by: @mum4k

Base: devel ← Head: vertical-labels

📝 Commits (6)

9f893eb Function to calculate required height.
7ef7939 xLabels now supports vertical labels.
3dba76c Linechart can now draw labels under X vertically.
5f6a843 Account for two labels on the Y axis.
369b866 Updating CHANGELOG.
11286f6 Improving test coverage of label.go.

📊 Changes

9 files changed (+616 additions, -112 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 draw/testdraw/testdraw.go (+7 -0)
📝 widgets/linechart/axes/axes.go (+52 -23)
📝 widgets/linechart/axes/axes_test.go (+231 -64)
📝 widgets/linechart/axes/label.go (+36 -4)
📝 widgets/linechart/axes/label_test.go (+143 -9)
📝 widgets/linechart/linechart.go (+21 -6)
📝 widgets/linechart/linechart_test.go (+104 -2)
📝 widgets/linechart/options.go (+21 -4)

📄 Description

Fixes #43

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mum4k/termdash/pull/122 **Author:** [@mum4k](https://github.com/mum4k) **Created:** 2/14/2019 **Status:** ✅ Merged **Merged:** 2/14/2019 **Merged by:** [@mum4k](https://github.com/mum4k) **Base:** `devel` ← **Head:** `vertical-labels` --- ### 📝 Commits (6) - [`9f893eb`](https://github.com/mum4k/termdash/commit/9f893eb482e7ba16b45a14453ff2eb61e35d03e6) Function to calculate required height. - [`7ef7939`](https://github.com/mum4k/termdash/commit/7ef79393df940db3c6a9063339c08481f02fc4ca) xLabels now supports vertical labels. - [`3dba76c`](https://github.com/mum4k/termdash/commit/3dba76c26ffcdb54fe46ac7c4e2041a12a6b53fa) Linechart can now draw labels under X vertically. - [`5f6a843`](https://github.com/mum4k/termdash/commit/5f6a84314cd949b2bdd2655bfca4c3325e741c05) Account for two labels on the Y axis. - [`369b866`](https://github.com/mum4k/termdash/commit/369b86604c17a5a989ec1f00d44b954f8ab596be) Updating CHANGELOG. - [`11286f6`](https://github.com/mum4k/termdash/commit/11286f6ff6ce4fbb9b77f8393a79607de8a9bcec) Improving test coverage of label.go. ### 📊 Changes **9 files changed** (+616 additions, -112 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `draw/testdraw/testdraw.go` (+7 -0) 📝 `widgets/linechart/axes/axes.go` (+52 -23) 📝 `widgets/linechart/axes/axes_test.go` (+231 -64) 📝 `widgets/linechart/axes/label.go` (+36 -4) 📝 `widgets/linechart/axes/label_test.go` (+143 -9) 📝 `widgets/linechart/linechart.go` (+21 -6) 📝 `widgets/linechart/linechart_test.go` (+104 -2) 📝 `widgets/linechart/options.go` (+21 -4) </details> ### 📄 Description Fixes #43 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>