[PR #119] [MERGED] Hotfix v0.6.1 #205

Closed
opened 2026-03-03 16:23:18 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/mum4k/termdash/pull/119
Author: @mum4k
Created: 2/13/2019
Status: Merged
Merged: 2/13/2019
Merged by: @mum4k

Base: masterHead: hotfix-0.6.1


📝 Commits (2)

  • 23c01a5 The LineChart widget now correctly places custom labels.
  • 9df48f9 Undo the experiment in the demo.

📊 Changes

3 files changed (+41 additions, -16 deletions)

View changed files

📝 CHANGELOG.md (+8 -1)
📝 widgets/linechart/axes/label.go (+13 -15)
📝 widgets/linechart/axes/label_test.go (+20 -0)

📄 Description

The LineChart widget now correctly places custom labels.

  • The code incorrectly used label number rather than value position when
    looking up custom labels.

Fixes #117


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mum4k/termdash/pull/119 **Author:** [@mum4k](https://github.com/mum4k) **Created:** 2/13/2019 **Status:** ✅ Merged **Merged:** 2/13/2019 **Merged by:** [@mum4k](https://github.com/mum4k) **Base:** `master` ← **Head:** `hotfix-0.6.1` --- ### 📝 Commits (2) - [`23c01a5`](https://github.com/mum4k/termdash/commit/23c01a5c562c2a4a7acaa89906a1b4b8cc3cdcd0) The LineChart widget now correctly places custom labels. - [`9df48f9`](https://github.com/mum4k/termdash/commit/9df48f906090a09431d09072346e7ace1a9a6d4b) Undo the experiment in the demo. ### 📊 Changes **3 files changed** (+41 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+8 -1) 📝 `widgets/linechart/axes/label.go` (+13 -15) 📝 `widgets/linechart/axes/label_test.go` (+20 -0) </details> ### 📄 Description The LineChart widget now correctly places custom labels. - The code incorrectly used label number rather than value position when looking up custom labels. Fixes #117 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 16:23:18 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/termdash#205
No description provided.