[PR #38] [MERGED] Adds full-width rune support. #172

New issue

Closed

opened 2026-03-03 16:23:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:23:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mum4k/termdash/pull/38
Author: @mum4k
Created: 5/20/2018
Status: ✅ Merged
Merged: 6/4/2018
Merged by: @mum4k

Base: master ← Head: text-widget/6/wide-runes

📝 Commits (9)

0049acb Full-width rune support in the cell buffer.
bb0e4b9 Move SetCell logic from faketerm to cell buffer.
ba2cb94 Full-width rune support in the canvas.
c2dab55 The draw package now supports full-width runes.
929bf2b The text widget now supports full-width runes.
7104472 Adding the text widget to the main README.
367af3f Merge branch 'text-widget/5/widget' into text-widget/6/wide-runes
1c17cb3 Updated doc as per comment.
5fd79c5 Merge branch 'master' into text-widget/6/wide-runes

📊 Changes

20 files changed (+1369 additions, -107 deletions)

View changed files

📝 README.md (+10 -2)
📝 canvas/canvas.go (+24 -9)
📝 canvas/canvas_test.go (+158 -2)
📝 canvas/testcanvas/testcanvas.go (+7 -3)
📝 cell/cell.go (+92 -0)
📝 cell/cell_test.go (+324 -0)
📝 draw/border.go (+5 -1)
📝 draw/rectangle.go (+5 -1)
📝 draw/rectangle_test.go (+9 -0)
📝 draw/text.go (+38 -14)
📝 draw/text_test.go (+133 -2)
📝 images/gaugedemo.gif (+0 -0)
➕ images/textdemo.gif (+0 -0)
📝 terminal/faketerm/faketerm.go (+1 -10)
📝 widgets/text/line_scanner.go (+7 -6)
📝 widgets/text/line_scanner_test.go (+59 -6)
➕ widgets/text/line_trim.go (+102 -0)
➕ widgets/text/line_trim_test.go (+268 -0)
📝 widgets/text/text.go (+68 -48)
📝 widgets/text/text_test.go (+59 -3)

📄 Description

Removes most of the assumptions that a rune only occupies only one cell on the terminal. What remains will be tracked in #37

Fixes #29

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mum4k/termdash/pull/38 **Author:** [@mum4k](https://github.com/mum4k) **Created:** 5/20/2018 **Status:** ✅ Merged **Merged:** 6/4/2018 **Merged by:** [@mum4k](https://github.com/mum4k) **Base:** `master` ← **Head:** `text-widget/6/wide-runes` --- ### 📝 Commits (9) - [`0049acb`](https://github.com/mum4k/termdash/commit/0049acbd01b0e3a83747568dff34085d43c39fe4) Full-width rune support in the cell buffer. - [`bb0e4b9`](https://github.com/mum4k/termdash/commit/bb0e4b9a58f10bc5a669645c751b9f426efffb48) Move SetCell logic from faketerm to cell buffer. - [`ba2cb94`](https://github.com/mum4k/termdash/commit/ba2cb94100dba792b308523ab129998278b12600) Full-width rune support in the canvas. - [`c2dab55`](https://github.com/mum4k/termdash/commit/c2dab55b507608323d71c85c43e35b402f61de56) The draw package now supports full-width runes. - [`929bf2b`](https://github.com/mum4k/termdash/commit/929bf2b8fcabb9482735963de8ae51d4291e0d20) The text widget now supports full-width runes. - [`7104472`](https://github.com/mum4k/termdash/commit/7104472cfad79a9755b162e124bc96190af02a74) Adding the text widget to the main README. - [`367af3f`](https://github.com/mum4k/termdash/commit/367af3f86d8dcb217af22f0cc1fc28237ee8e605) Merge branch 'text-widget/5/widget' into text-widget/6/wide-runes - [`1c17cb3`](https://github.com/mum4k/termdash/commit/1c17cb36f2f503291baef654e70ee2d6fd9fa752) Updated doc as per comment. - [`5fd79c5`](https://github.com/mum4k/termdash/commit/5fd79c5d9ecae7fd68930fe026f88ed06af46c98) Merge branch 'master' into text-widget/6/wide-runes ### 📊 Changes **20 files changed** (+1369 additions, -107 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+10 -2) 📝 `canvas/canvas.go` (+24 -9) 📝 `canvas/canvas_test.go` (+158 -2) 📝 `canvas/testcanvas/testcanvas.go` (+7 -3) 📝 `cell/cell.go` (+92 -0) 📝 `cell/cell_test.go` (+324 -0) 📝 `draw/border.go` (+5 -1) 📝 `draw/rectangle.go` (+5 -1) 📝 `draw/rectangle_test.go` (+9 -0) 📝 `draw/text.go` (+38 -14) 📝 `draw/text_test.go` (+133 -2) 📝 `images/gaugedemo.gif` (+0 -0) ➕ `images/textdemo.gif` (+0 -0) 📝 `terminal/faketerm/faketerm.go` (+1 -10) 📝 `widgets/text/line_scanner.go` (+7 -6) 📝 `widgets/text/line_scanner_test.go` (+59 -6) ➕ `widgets/text/line_trim.go` (+102 -0) ➕ `widgets/text/line_trim_test.go` (+268 -0) 📝 `widgets/text/text.go` (+68 -48) 📝 `widgets/text/text_test.go` (+59 -3) </details> ### 📄 Description Removes most of the assumptions that a rune only occupies only one cell on the terminal. What remains will be tracked in #37 Fixes #29 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>