[PR #39] [MERGED] Support for full-width runes in the remaining code. #171

New issue

Closed

opened 2026-03-03 16:23:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:23:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mum4k/termdash/pull/39
Author: @mum4k
Created: 5/27/2018
Status: ✅ Merged
Merged: 6/13/2018
Merged by: @mum4k

Base: master ← Head: bugfix-rune-count

📝 Commits (8)

9786171 Faketerm and diff on it supports partial cells.
c148d8c Alignment now supports full-width runes.
8a1bb34 Generalized text trimming logic.
945b48f Gauge widget now supports full-width runes.
e5ca702 Updating the gaugedemo image.
4058126 Merge branch 'master' into bugfix-rune-count
870e1bd Merge branch 'master' into bugfix-rune-count
b989483 Comment from @chipmunkie.

📊 Changes

13 files changed (+382 additions, -89 deletions)

View changed files

📝 align/align.go (+5 -4)
📝 align/align_test.go (+9 -1)
📝 draw/border_test.go (+18 -6)
📝 draw/rectangle.go (+4 -2)
📝 draw/text.go (+29 -28)
📝 draw/text_test.go (+182 -0)
📝 images/gaugedemo.gif (+0 -0)
📝 terminal/faketerm/diff.go (+7 -1)
📝 terminal/faketerm/faketerm.go (+6 -1)
📝 widgets/gauge/demo/gaugedemo.go (+1 -1)
📝 widgets/gauge/gauge.go (+41 -44)
📝 widgets/gauge/gauge_test.go (+79 -1)
📝 widgets/gauge/options.go (+1 -0)

📄 Description

Support alignment of text with full-width runes.
Generalise text trimming logic.
Gauge widget now supports full-width runes.
Skip over partial cells when diffing fake terminals.

Fixes #37

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mum4k/termdash/pull/39 **Author:** [@mum4k](https://github.com/mum4k) **Created:** 5/27/2018 **Status:** ✅ Merged **Merged:** 6/13/2018 **Merged by:** [@mum4k](https://github.com/mum4k) **Base:** `master` ← **Head:** `bugfix-rune-count` --- ### 📝 Commits (8) - [`9786171`](https://github.com/mum4k/termdash/commit/9786171a7a5226543b70990d7a343e4c2c220eb4) Faketerm and diff on it supports partial cells. - [`c148d8c`](https://github.com/mum4k/termdash/commit/c148d8c1710df07236f3364b7dd6a0a17b6c672b) Alignment now supports full-width runes. - [`8a1bb34`](https://github.com/mum4k/termdash/commit/8a1bb34b05958e84c1bec7791083e2dbdd3e39b0) Generalized text trimming logic. - [`945b48f`](https://github.com/mum4k/termdash/commit/945b48f4a37647e3c4dde583655a835a1478bfb1) Gauge widget now supports full-width runes. - [`e5ca702`](https://github.com/mum4k/termdash/commit/e5ca7023ef15d18673273d64fa9ee2f8e47e5d00) Updating the gaugedemo image. - [`4058126`](https://github.com/mum4k/termdash/commit/405812665a6f1796ec55f01e151b93a2c79bc5f4) Merge branch 'master' into bugfix-rune-count - [`870e1bd`](https://github.com/mum4k/termdash/commit/870e1bda0011b80c8193d9b3c4ed2363f4fd202e) Merge branch 'master' into bugfix-rune-count - [`b989483`](https://github.com/mum4k/termdash/commit/b98948326b255c2cc9b6186922a0da56fd2eba58) Comment from @chipmunkie. ### 📊 Changes **13 files changed** (+382 additions, -89 deletions) <details> <summary>View changed files</summary> 📝 `align/align.go` (+5 -4) 📝 `align/align_test.go` (+9 -1) 📝 `draw/border_test.go` (+18 -6) 📝 `draw/rectangle.go` (+4 -2) 📝 `draw/text.go` (+29 -28) 📝 `draw/text_test.go` (+182 -0) 📝 `images/gaugedemo.gif` (+0 -0) 📝 `terminal/faketerm/diff.go` (+7 -1) 📝 `terminal/faketerm/faketerm.go` (+6 -1) 📝 `widgets/gauge/demo/gaugedemo.go` (+1 -1) 📝 `widgets/gauge/gauge.go` (+41 -44) 📝 `widgets/gauge/gauge_test.go` (+79 -1) 📝 `widgets/gauge/options.go` (+1 -0) </details> ### 📄 Description - Support alignment of text with full-width runes. - Generalise text trimming logic. - Gauge widget now supports full-width runes. - Skip over partial cells when diffing fake terminals. Fixes #37 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>