mirror of
https://github.com/mum4k/termdash.git
synced 2026-04-27 03:15:55 +03:00
[GH-ISSUE #360] Panic when attempting to use Backtab #160
Labels
No labels
bug
cleanup
enhancement
enhancement
enhancement
good first issue
help wanted
help wanted
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/termdash#160
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @spacez320 on GitHub (Jan 11, 2024).
Original GitHub issue: https://github.com/mum4k/termdash/issues/360
Originally assigned to: @spacez320 on GitHub.
Pressing the 'backtab' key (a.k.a. Shift + Tab) throws an error in Termdash.
This is a supported key in Tcell, at least. https://godocs.io/github.com/gdamore/tcell/v2#Key
Currently I have my program throwing away the error with a handler, but would be nice to properly support the key press.
@mum4k commented on GitHub (Jan 11, 2024):
Thank you for reporting this @spacez320. Termdash has an intermediate terminalapi layer that allows its users to switch between different implementations (tcell Vs. termbox).
It is in this layer that keys are processed and mapped from specific implementations to Termdash implementation. Looks like all we need to do is support mapping of
backtaband maybe a few additional events that were added in the meantime. The support should be added here.Is this something you would be interested in contributing?
@spacez320 commented on GitHub (Jan 11, 2024):
@mum4k Thanks for the response. I'd be happy to contribute this. Let me know if there's a time table, but otherwise should be able to report back soon.
@mum4k commented on GitHub (Jan 11, 2024):
Thank you @spacez320, no rush - I don't keep any regular release schedule for Termdash. We can tag a new version once we have your PR in.
Thank you for your help!
@spacez320 commented on GitHub (Jan 27, 2024):
Thanks @mum4k . I have a PR here: https://github.com/mum4k/termdash/pull/362, let me know how it looks.
I didn't touch termbox (it didn't seem tab was really used in that library?), let me know if I should or if I missed some events I should have implemented, or anything else.