mirror of
https://github.com/mum4k/termdash.git
synced 2026-04-26 19:05:52 +03:00
[GH-ISSUE #332] adding text styles has no effect on Windows #155
Labels
No labels
bug
cleanup
enhancement
enhancement
enhancement
good first issue
help wanted
help wanted
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/termdash#155
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @icy-comet on GitHub (Jul 8, 2022).
Original GitHub issue: https://github.com/mum4k/termdash/issues/332
I am on the
develbranch oftermdashand I passed 4 different styles withtext.WriteCellOptsto thetext.Writecall for testing the result. Except, I found only theblinkstyle to be working, as seen in the attached image.Is this an implementation issue at
termdash's end or a bug in the upstream libtcell?I also tested the same thing with
termdash v0.16.0which was before merging #329, but had the same outcome.PS: I know that the styling works on my device because golang-based OhMyPosh, which handles ANSI codes differently, works with all the 4 styles.
@icy-comet commented on GitHub (Jul 8, 2022):
I just tested the same program inside WSL, and all the styles work fine with the Linux build.
@mum4k commented on GitHub (Jul 8, 2022):
Thank you for reporting this @icy-comet, considering this works in Linux, chances are the problem is in upstream
tcell. We could start by verifying if thetcellsupport works as expected by runningtcellnatively withouttermdashon windows and selecting these options.@icy-comet please indicate if you are interested in looking into this issue.
@icy-comet commented on GitHub (Jul 10, 2022):
Seems like it @mum4k.
I just put together a test file according to
tcell's getting started guide for 4 text styles —italic,bold,blinkanddim.Here are the results:
blinkstyle worksblinkandboldstyles workboldstyle doesn't workHere's the gist I used for testing:
https://gist.github.com/icy-comet/76cc7fdbb77f272c5653e533ddebdb63
@icy-comet commented on GitHub (Jul 10, 2022):
I just opened an issue describing this at
tcell's issue tracker: gdamore/tcell#539@mum4k commented on GitHub (Jul 14, 2022):
Thank you for following up upstream @icy-comet.