[GH-ISSUE #328] add dim text style as cell.Option #151

New issue

Closed

opened 2026-03-03 16:22:54 +03:00 by kerem · 1 comment

kerem commented

2026-03-03 16:22:54 +03:00

Owner

Originally created by @icy-comet on GitHub (Jun 28, 2022).
Original GitHub issue: https://github.com/mum4k/termdash/issues/328

I noticed that termdash/cell maps one-to-one to the styles provided by the tcell API.
github.com/mum4k/termdash@f13e4222fa/terminal/tcell/cell_options.go (L59-L75)

However, the "dim" style from the tcell package is missing from this mapping. If this is not a deliberate decision, adding the style would be a "nice-to-have".

Originally created by @icy-comet on GitHub (Jun 28, 2022). Original GitHub issue: https://github.com/mum4k/termdash/issues/328 I noticed that `termdash/cell` maps one-to-one to the styles provided by the `tcell` API. https://github.com/mum4k/termdash/blob/f13e4222fa62b251e937fa2a00ffab003d814f13/terminal/tcell/cell_options.go#L59-L75 However, the ["dim" style from the tcell package](https://pkg.go.dev/github.com/gdamore/tcell/v2#Style.Dim) is missing from this mapping. If this is not a deliberate decision, adding the style would be a "nice-to-have".

kerem closed this issue

2026-03-03 16:22:55 +03:00

kerem commented

2026-03-03 16:22:55 +03:00

Author

Owner

@mum4k commented on GitHub (Jun 30, 2022):

Hi @icy-comet, thank you for pointing this out. I suspect this is because the "dim" style isn't supported by termbox, which was the initial terminal driver termdash was built upon. We can add the "dim" style and just make the appropriate disclaimers and error messages when termbox is being used.

Is this something you are interested in contributing?

@mum4k commented on GitHub (Jun 30, 2022): Hi @icy-comet, thank you for pointing this out. I suspect this is because the "dim" style isn't supported by [termbox](https://github.com/nsf/termbox), which was the initial terminal driver termdash was built upon. We can add the "dim" style and just make the appropriate disclaimers and error messages when termbox is being used. Is this something you are interested in contributing?

kerem referenced this issue

2026-03-03 16:23:23 +03:00

[PR #151] [MERGED] Refactoring the codebase to clearly mark internal libraries. #222