[GH-ISSUE #245] Windows console not drawing scroll arrows #133

Closed
opened 2026-03-03 16:22:40 +03:00 by kerem · 6 comments
Owner

Originally created by @emesare on GitHub (Sep 30, 2020).
Original GitHub issue: https://github.com/mum4k/termdash/issues/245

Originally assigned to: @emesare on GitHub.

github.com/mum4k/termdash@fe3e973531/widgets/text/text.go (L128)
github.com/mum4k/termdash@fe3e973531/widgets/text/text.go (L147)
These characters are unable to be drawn in the windows console, or at least in the current rendition.
maybe give an option to the text widget to swap the scroll up and down arrows out for ▲ and ▼ (or ↑ and ↓)?

Originally created by @emesare on GitHub (Sep 30, 2020). Original GitHub issue: https://github.com/mum4k/termdash/issues/245 Originally assigned to: @emesare on GitHub. https://github.com/mum4k/termdash/blob/fe3e973531917978dd6d412520528bf10e092087/widgets/text/text.go#L128 https://github.com/mum4k/termdash/blob/fe3e973531917978dd6d412520528bf10e092087/widgets/text/text.go#L147 [These characters are unable to be drawn in the windows console, or at least in the current rendition.](https://i.imgur.com/FwhQTdM.png) maybe give an option to the text widget to swap the scroll up and down arrows out for ▲ and ▼ (or ↑ and ↓)?
Author
Owner

@mum4k commented on GitHub (Oct 4, 2020):

Hi @d-ank, thank you for the suggestion. I agree that this is a good solution and should be fairly trivial to implement.

Is this something you would be willing to contribute?

<!-- gh-comment-id:703191246 --> @mum4k commented on GitHub (Oct 4, 2020): Hi @d-ank, thank you for the suggestion. I agree that this is a good solution and should be fairly trivial to implement. Is this something you would be willing to contribute?
Author
Owner

@Amirhossein2000 commented on GitHub (Oct 9, 2020):

Hi

cells, err := cvs.SetCell(cur, '⇧') --> cells, err := cvs.SetCell(cur, ' ▲')

Is the solution as easy as this or I'm wrong?

<!-- gh-comment-id:706391023 --> @Amirhossein2000 commented on GitHub (Oct 9, 2020): Hi ```Go cells, err := cvs.SetCell(cur, '⇧') --> cells, err := cvs.SetCell(cur, ' ▲') ``` Is the solution as easy as this or I'm wrong?
Author
Owner

@emesare commented on GitHub (Oct 12, 2020):

Sorry for the delayed response, I will put in a pr in when I am at my desktop.

<!-- gh-comment-id:707366098 --> @emesare commented on GitHub (Oct 12, 2020): Sorry for the delayed response, I will put in a pr in when I am at my desktop.
Author
Owner

@mum4k commented on GitHub (Oct 13, 2020):

@Amirhossein2000 that is the essence of the code change, yes. However if done like this, it would change the default behavior for all the users. What might be better is for us to add an option that would allow the user to specify the character to use in place of the arrows. One example of implementing such option is in the Gauge widget that allows setting a custom Gauge character:

github.com/mum4k/termdash@fe3e973531/widgets/gauge/options.go (L83-L89)

@d-ank no pressure, take your time and thank you for looking into this.

<!-- gh-comment-id:707443224 --> @mum4k commented on GitHub (Oct 13, 2020): @Amirhossein2000 that is the essence of the code change, yes. However if done like this, it would change the default behavior for all the users. What might be better is for us to add an option that would allow the user to specify the character to use in place of the arrows. One example of implementing such option is in the Gauge widget that allows setting a custom Gauge character: https://github.com/mum4k/termdash/blob/fe3e973531917978dd6d412520528bf10e092087/widgets/gauge/options.go#L83-L89 @d-ank no pressure, take your time and thank you for looking into this.
Author
Owner

@emesare commented on GitHub (Oct 13, 2020):

https://github.com/mum4k/termdash/pull/248 Here is the accompanying fix and addition.

<!-- gh-comment-id:707487064 --> @emesare commented on GitHub (Oct 13, 2020): https://github.com/mum4k/termdash/pull/248 Here is the accompanying fix and addition.
Author
Owner

@mum4k commented on GitHub (Nov 18, 2020):

Released in #266.

<!-- gh-comment-id:729400209 --> @mum4k commented on GitHub (Nov 18, 2020): Released in #266.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/termdash#133
No description provided.