mirror of
https://github.com/mum4k/termdash.git
synced 2026-04-27 11:25:53 +03:00
[GH-ISSUE #245] Windows console not drawing scroll arrows #133
Labels
No labels
bug
cleanup
enhancement
enhancement
enhancement
good first issue
help wanted
help wanted
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/termdash#133
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @emesare on GitHub (Sep 30, 2020).
Original GitHub issue: https://github.com/mum4k/termdash/issues/245
Originally assigned to: @emesare on GitHub.
github.com/mum4k/termdash@fe3e973531/widgets/text/text.go (L128)github.com/mum4k/termdash@fe3e973531/widgets/text/text.go (L147)These characters are unable to be drawn in the windows console, or at least in the current rendition.
maybe give an option to the text widget to swap the scroll up and down arrows out for ▲ and ▼ (or ↑ and ↓)?
@mum4k commented on GitHub (Oct 4, 2020):
Hi @d-ank, thank you for the suggestion. I agree that this is a good solution and should be fairly trivial to implement.
Is this something you would be willing to contribute?
@Amirhossein2000 commented on GitHub (Oct 9, 2020):
Hi
Is the solution as easy as this or I'm wrong?
@emesare commented on GitHub (Oct 12, 2020):
Sorry for the delayed response, I will put in a pr in when I am at my desktop.
@mum4k commented on GitHub (Oct 13, 2020):
@Amirhossein2000 that is the essence of the code change, yes. However if done like this, it would change the default behavior for all the users. What might be better is for us to add an option that would allow the user to specify the character to use in place of the arrows. One example of implementing such option is in the Gauge widget that allows setting a custom Gauge character:
github.com/mum4k/termdash@fe3e973531/widgets/gauge/options.go (L83-L89)@d-ank no pressure, take your time and thank you for looking into this.
@emesare commented on GitHub (Oct 13, 2020):
https://github.com/mum4k/termdash/pull/248 Here is the accompanying fix and addition.
@mum4k commented on GitHub (Nov 18, 2020):
Released in #266.