[GH-ISSUE #166] ios/add domain override: trailing dot in the DNS name #44

New issue

Closed

opened 2026-03-04 01:34:22 +03:00 by kerem · 3 comments

kerem commented

2026-03-04 01:34:22 +03:00

Owner

Originally created by @0vercl0k on GitHub (Jun 8, 2023).
Original GitHub issue: https://github.com/spr-networks/super/issues/166

Originally assigned to: @lts-rad on GitHub.

I added a domain override using the 'Add Domain Override' menu but the DNS name included a trailing .; like foo.com..

Originally created by @0vercl0k on GitHub (Jun 8, 2023). Original GitHub issue: https://github.com/spr-networks/super/issues/166 Originally assigned to: @lts-rad on GitHub. I added a domain override using the 'Add Domain Override' menu but the DNS name included a trailing `.`; like `foo.com.`.

kerem closed this issue

2026-03-04 01:34:22 +03:00

kerem commented

2026-03-04 01:34:23 +03:00

Author

Owner

@lts-rad commented on GitHub (Jun 8, 2023):

Can clean up the UI here. It should work okay, I need to recall the reasoning for the trailing .

@lts-rad commented on GitHub (Jun 8, 2023): Can clean up the UI here. It should work okay, I need to recall the reasoning for the trailing .

kerem commented

2026-03-04 01:34:23 +03:00

Author

Owner

@0vercl0k commented on GitHub (Jun 8, 2023):

Oh interesting, I guess I didn't try to validate 😅 Also, the entry appears w/ the IP of the client once it has been added; it'd be nice if it could also show the associated name.

@0vercl0k commented on GitHub (Jun 8, 2023): Oh interesting, I guess I didn't try to validate 😅 Also, the entry appears w/ the IP of the client once it has been added; it'd be nice if it could also show the associated name.

kerem commented

2026-03-04 01:34:23 +03:00

Author

Owner

@lts-rad commented on GitHub (Jun 8, 2023):

yep can do re client names

to add some details on the trailing dot:

the name matching is recursive
https://github.com/spr-networks/coredns-block/blob/master/block.go#L384
the trailing dot makes it so that the end match is required so it doesnt match a prefix by mistake

@lts-rad commented on GitHub (Jun 8, 2023): yep can do re client names to add some details on the trailing dot: the name matching is recursive https://github.com/spr-networks/coredns-block/blob/master/block.go#L384 the trailing dot makes it so that the end match is required so it doesnt match a prefix by mistake

kerem referenced this issue

2026-03-04 01:36:01 +03:00

[PR #44] [MERGED] Dev #270