[PR #128] [MERGED] Dhcp rewrite #333

New issue

Closed

opened 2026-03-04 01:36:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:36:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/spr-networks/super/pull/128
Author: @lts-rad
Created: 4/10/2023
Status: ✅ Merged
Merged: 4/12/2023
Merged by: @lts-rad

Base: dev ← Head: dhcp-rewrite

📝 Commits (10+)

7c347bf [db] Add sleep on failure
e3d9ce8 [build] Remove deprecated zones
e9b2b58 [api] Support new DHCP mechanisms
3b51d6a [wireguard] No longer call into coredhcp plugin, use API directly to get an IP address
d00d066 [api] API now generates DHCP addresses
e0be553 [api] Fix typo
52daff1 [base] Remove TINYNET variables
0f32745 [api] Fix os.Getenv call
3ded067 [dhcp] Remove dhcp helper script
a9ce59b [base] Add tiny_subnets plugin back in, no arguments

📊 Changes

35 files changed (+1093 additions, -255 deletions)

View changed files

📝 api/code/api.go (+46 -169)
➕ api/code/dhcp.go (+702 -0)
📝 api/code/firewall.go (+75 -9)
📝 api/code/go.mod (+1 -1)
📝 api/code/go.sum (+2 -0)
📝 api/code/notifications.go (+11 -2)
📝 base/scripts/nft_rules.sh (+8 -2)
📝 base/scripts/startup.sh (+2 -1)
📝 base/template_configs/base/api.json (+7 -1)
📝 base/template_configs/base/config.sh (+0 -6)
➕ base/template_configs/base/dhcp.json (+1 -0)
➕ base/template_configs/base/lanip (+1 -0)
📝 base/template_configs/base/virtual-config.sh (+0 -6)
📝 base/template_configs/scripts/gen_coredhcp_yaml.sh (+1 -7)
📝 db/code/cmd/boltapi/main.go (+1 -0)
📝 dhcp/Dockerfile (+1 -0)
➖ dhcp/scripts/dhcp_helper.sh (+0 -12)
📝 docker-compose-test.yml (+0 -2)
📝 docker-compose-virt.yml (+0 -2)
📝 docker-compose.yml (+0 -2)

...and 15 more files

📄 Description

This repositions IP management from Coredhcp's leases file into the API.

This is needed to support IP address reassignment and supporting multiple subnets.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/spr-networks/super/pull/128 **Author:** [@lts-rad](https://github.com/lts-rad) **Created:** 4/10/2023 **Status:** ✅ Merged **Merged:** 4/12/2023 **Merged by:** [@lts-rad](https://github.com/lts-rad) **Base:** `dev` ← **Head:** `dhcp-rewrite` --- ### 📝 Commits (10+) - [`7c347bf`](https://github.com/spr-networks/super/commit/7c347bf3c41306072af2c11015ba27551e2d461a) [db] Add sleep on failure - [`e3d9ce8`](https://github.com/spr-networks/super/commit/e3d9ce84a5f5a2575e3e776fe117f67b32fac1dd) [build] Remove deprecated zones - [`e9b2b58`](https://github.com/spr-networks/super/commit/e9b2b584e06a34899131a00b08f9a767565fecdf) [api] Support new DHCP mechanisms - [`3b51d6a`](https://github.com/spr-networks/super/commit/3b51d6a4b6f641a0147fe82ce6d62626b6b9f9d6) [wireguard] No longer call into coredhcp plugin, use API directly to get an IP address - [`d00d066`](https://github.com/spr-networks/super/commit/d00d066f9fc6a01fe9d5c4c90475706dcb548c98) [api] API now generates DHCP addresses - [`e0be553`](https://github.com/spr-networks/super/commit/e0be55397f06788c9df74aee2a95e8265af4747b) [api] Fix typo - [`52daff1`](https://github.com/spr-networks/super/commit/52daff1a6c55ffd881a49c244407e8e7dc425593) [base] Remove TINYNET variables - [`0f32745`](https://github.com/spr-networks/super/commit/0f32745df5b3b1ef54368fb9e025878c66da4a88) [api] Fix os.Getenv call - [`3ded067`](https://github.com/spr-networks/super/commit/3ded0678e33d03084d08a0069cd492cf077a5ee8) [dhcp] Remove dhcp helper script - [`a9ce59b`](https://github.com/spr-networks/super/commit/a9ce59b762af6e31ce6048f312f14988b92c7e9c) [base] Add tiny_subnets plugin back in, no arguments ### 📊 Changes **35 files changed** (+1093 additions, -255 deletions) <details> <summary>View changed files</summary> 📝 `api/code/api.go` (+46 -169) ➕ `api/code/dhcp.go` (+702 -0) 📝 `api/code/firewall.go` (+75 -9) 📝 `api/code/go.mod` (+1 -1) 📝 `api/code/go.sum` (+2 -0) 📝 `api/code/notifications.go` (+11 -2) 📝 `base/scripts/nft_rules.sh` (+8 -2) 📝 `base/scripts/startup.sh` (+2 -1) 📝 `base/template_configs/base/api.json` (+7 -1) 📝 `base/template_configs/base/config.sh` (+0 -6) ➕ `base/template_configs/base/dhcp.json` (+1 -0) ➕ `base/template_configs/base/lanip` (+1 -0) 📝 `base/template_configs/base/virtual-config.sh` (+0 -6) 📝 `base/template_configs/scripts/gen_coredhcp_yaml.sh` (+1 -7) 📝 `db/code/cmd/boltapi/main.go` (+1 -0) 📝 `dhcp/Dockerfile` (+1 -0) ➖ `dhcp/scripts/dhcp_helper.sh` (+0 -12) 📝 `docker-compose-test.yml` (+0 -2) 📝 `docker-compose-virt.yml` (+0 -2) 📝 `docker-compose.yml` (+0 -2) _...and 15 more files_ </details> ### 📄 Description This repositions IP management from Coredhcp's leases file into the API. This is needed to support IP address reassignment and supporting multiple subnets. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>