[PR #48] [CLOSED] [ui] [build] Build the frontend for the native architecture #273

Closed
opened 2026-03-04 01:36:01 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/spr-networks/super/pull/48
Author: @rgov
Created: 8/9/2022
Status: Closed

Base: mainHead: rzg/native-frontend


📝 Commits (4)

  • 8049785 [ui] [build] Build the frontend for the native architecture
  • 29ab755 [build] Create temporary container with a dummy command
  • 6b853f6 [ui] [build] Only copy build products to container image
  • be7953a [build] Fix typo in argument

📊 Changes

4 files changed (+7 additions, -9 deletions)

View changed files

📝 .github/workflows/docker-image.yml (+1 -1)
📝 build_docker_compose.sh (+1 -1)
📝 frontend/Dockerfile (+2 -2)
📝 frontend/gen_frontend.sh (+3 -5)

📄 Description

This modifies the build container in the multi-stage build to always use the native architecture, since the resulting JavaScript files are platform independent. This will still result in linux/amd64 and linux/arm64 images in the end, but the code will only have to be built once.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/spr-networks/super/pull/48 **Author:** [@rgov](https://github.com/rgov) **Created:** 8/9/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `rzg/native-frontend` --- ### 📝 Commits (4) - [`8049785`](https://github.com/spr-networks/super/commit/804978551969e2db7d709341c9623c4db2d3048d) [ui] [build] Build the frontend for the native architecture - [`29ab755`](https://github.com/spr-networks/super/commit/29ab75593e9ed2e77c7f3113ee6029316dea6d8d) [build] Create temporary container with a dummy command - [`6b853f6`](https://github.com/spr-networks/super/commit/6b853f65d02cee8524ed1499efaa33ac69fb7c46) [ui] [build] Only copy build products to container image - [`be7953a`](https://github.com/spr-networks/super/commit/be7953adcd20ec5265021a8a114f59971b149eb6) [build] Fix typo in argument ### 📊 Changes **4 files changed** (+7 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/docker-image.yml` (+1 -1) 📝 `build_docker_compose.sh` (+1 -1) 📝 `frontend/Dockerfile` (+2 -2) 📝 `frontend/gen_frontend.sh` (+3 -5) </details> ### 📄 Description This modifies the `build` container in the multi-stage build to always use the native architecture, since the resulting JavaScript files are platform independent. This will still result in `linux/amd64` and `linux/arm64` images in the end, but the code will only have to be built once. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 01:36:01 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/super#273
No description provided.