mirror of
https://github.com/spr-networks/super.git
synced 2026-04-25 04:45:51 +03:00
[PR #48] [CLOSED] [ui] [build] Build the frontend for the native architecture #273
Labels
No labels
blocked
bug
documentation
enhancement
fixed
fixed ✅
hardening
implemented
installer
multicast
p1
p2
pending
podman
pull-request
security
testing
v1
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/super#273
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/spr-networks/super/pull/48
Author: @rgov
Created: 8/9/2022
Status: ❌ Closed
Base:
main← Head:rzg/native-frontend📝 Commits (4)
8049785[ui] [build] Build the frontend for the native architecture29ab755[build] Create temporary container with a dummy command6b853f6[ui] [build] Only copy build products to container imagebe7953a[build] Fix typo in argument📊 Changes
4 files changed (+7 additions, -9 deletions)
View changed files
📝
.github/workflows/docker-image.yml(+1 -1)📝
build_docker_compose.sh(+1 -1)📝
frontend/Dockerfile(+2 -2)📝
frontend/gen_frontend.sh(+3 -5)📄 Description
This modifies the
buildcontainer in the multi-stage build to always use the native architecture, since the resulting JavaScript files are platform independent. This will still result inlinux/amd64andlinux/arm64images in the end, but the code will only have to be built once.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.