mirror of
https://github.com/spr-networks/super.git
synced 2026-04-25 04:45:51 +03:00
[GH-ISSUE #392] ios: Deleting a DNS override entry throw a API failure 400 #195
Labels
No labels
blocked
bug
documentation
enhancement
fixed
fixed ✅
hardening
implemented
installer
multicast
p1
p2
pending
podman
pull-request
security
testing
v1
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/super#195
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @0vercl0k on GitHub (Jan 2, 2025).
Original GitHub issue: https://github.com/spr-networks/super/issues/392
I've added a DNS override entry from the DNS log view; I browsed to a request that was blocked and used the UI to add a permit override.
Then, if I go into the Blocklist DNS view, and I swipe left on the entry and click delete, I get a 'API failure: 400' and the entry doesn't get deleted.
I haven't tried this through the web UI so this might be iOS specific bug.
Cheers
@lts-rad commented on GitHub (Jan 9, 2025):
I have not been able to reproduce this, if possible, can you DM me a screenshot
@0vercl0k commented on GitHub (Jan 10, 2025):
Just sent you a video (also does it with latest spr version released this week)!
Cheers
@lts-rad commented on GitHub (Jan 10, 2025):
looks like the ios codepath has a bug
DELETE /plugins/dns/block/override/%5Bobject%20Object%5D HTTP/1.1
@lts-rad commented on GitHub (Jan 10, 2025):
this was missed when refactoring override lists to get names (so we can do stuff like preopulate a list of common DOH domain rules). fixed now in dev
@0vercl0k commented on GitHub (Jan 10, 2025):
woot, thanks for chasing this down man!