[GH-ISSUE #320] UI: devices view fails when the example device has been deleted and no other non vpn only devices are present #149

New issue

Closed

opened 2026-03-04 01:35:10 +03:00 by kerem · 5 comments

kerem commented

2026-03-04 01:35:10 +03:00

Owner

Originally created by @lts-rad on GitHub (May 8, 2024).
Original GitHub issue: https://github.com/spr-networks/super/issues/320

Originally created by @lts-rad on GitHub (May 8, 2024). Original GitHub issue: https://github.com/spr-networks/super/issues/320

kerem

2026-03-04 01:35:10 +03:00

closed this issue
added the
bug

p1

v1

fixed ✅
labels

kerem commented

2026-03-04 01:35:11 +03:00

Author

Owner

@lts-rad commented on GitHub (May 8, 2024):

page redirects to validate. no otp code hsa been set

@lts-rad commented on GitHub (May 8, 2024): page redirects to validate. no otp code hsa been set <img width="652" alt="image" src="https://github.com/spr-networks/super/assets/37549748/92c6d961-1ea4-41c3-92c4-5b971cfd752b">

kerem commented

2026-03-04 01:35:11 +03:00

Author

Owner

@lts-rad commented on GitHub (May 8, 2024):

user reports this is not just virtual mode.

looking into it, the only request that is failing is the ouis lookup which 404s. then the UI incorrectly handles the 404 to validate the otp code

@lts-rad commented on GitHub (May 8, 2024): user reports this is not just virtual mode. looking into it, the only request that is failing is the ouis lookup which 404s. then the UI incorrectly handles the 404 to validate the otp code

kerem commented

2026-03-04 01:35:11 +03:00

Author

Owner

@lts-rad commented on GitHub (May 8, 2024):

bug does not appear to reproduce with this change

        if (macs && macs.length > 0) {
          // set device oui if avail
          deviceAPI
            .ouis(macs)
            .then((ouis) => {
              let devs = devices.map((d) => {
                let oui = ouis.find((o) => o.MAC == d.MAC)
                d.oui = oui ? oui.Vendor : ''
                return d
              })

              setList(devs.sort(sortDevices))
            })
            .catch((err) => {})
        }

but we need a more extensive fix

@lts-rad commented on GitHub (May 8, 2024): bug does not appear to reproduce with this change ``` if (macs && macs.length > 0) { // set device oui if avail deviceAPI .ouis(macs) .then((ouis) => { let devs = devices.map((d) => { let oui = ouis.find((o) => o.MAC == d.MAC) d.oui = oui ? oui.Vendor : '' return d }) setList(devs.sort(sortDevices)) }) .catch((err) => {}) } ``` but we need a more extensive fix

kerem commented

2026-03-04 01:35:11 +03:00

Author

Owner

@lts-rad commented on GitHub (May 8, 2024):

the issue is the empty lookup triggers the redirect http://127.0.0.1:8009/plugins/lookup/ouis/ which incorrectly assumes otp failure

@lts-rad commented on GitHub (May 8, 2024): the issue is the empty lookup triggers the redirect http://127.0.0.1:8009/plugins/lookup/ouis/ which incorrectly assumes otp failure

kerem commented

2026-03-04 01:35:11 +03:00

Author

Owner

@lts-rad commented on GitHub (May 9, 2024):

this is fixed correctly by 18f7882c8e

@lts-rad commented on GitHub (May 9, 2024): this is fixed correctly by 18f7882c8e8972aa8ba35680c47d012f71a5b4ac