mirror of
https://github.com/spr-networks/super.git
synced 2026-04-24 20:35:55 +03:00
[GH-ISSUE #306] ios: DNS override, hard to tell when deleting an entry #141
Labels
No labels
blocked
bug
documentation
enhancement
fixed
fixed ✅
hardening
implemented
installer
multicast
p1
p2
pending
podman
pull-request
security
testing
v1
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/super#141
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @0vercl0k on GitHub (Apr 5, 2024).
Original GitHub issue: https://github.com/spr-networks/super/issues/306
On the iOS app, when trying to delete a DNS override entry, it is pretty hard to click on the red ❌ button as it is small; and somehow you also don't get any feedback when a click has been dispatched. That plus a small lag lead to clicking several times in a row and deleting multiple entries.
I can probably try to make a video if that's useful, but it wouldn't even be visible when I am tapping on the screen so not sure it'd be super useful.
Cheers
@0vercl0k commented on GitHub (Apr 12, 2024):
I also noticed that this control is also used in the DNS logging settings UI and it has the same effect; you never know when you properly the ❌ and sometime end up deleting two entries when you wanted to delete one
@lts-po commented on GitHub (Apr 18, 2024):
Pushed a new version to TestFlight with a swipelist similar to device listing - check if this is better. Plan is if it works, we move more of the listings to this layout for iOS (blocklists, rules, groups, any listing) & add more buttons to the hidden view.
Thanks again!
@0vercl0k commented on GitHub (Apr 21, 2024):
Woot this is looking great!
@0vercl0k commented on GitHub (May 10, 2024):
The 'Dns Log Settings' / 'Host Privacy IP List' seems to have the old little red ❌; not sure if it was missed or it regressed somehow?
@lts-rad commented on GitHub (May 10, 2024):
looking into it now, this view disappeared from routes and wasnt rendering properly on web. as for whyios is not picking up the swipelist im not sure. i dont actually see a code change for settings for using DNSOverrideListItem which got the swipe list in
github.com/spr-networks/super@340b5dff03@lts-rad commented on GitHub (May 10, 2024):
xcrun is currently failing for the PR. https://github.com/spr-networks/super/actions/runs/9026717967/job/24804460927 . its possible testflight is grabbing the wrong version
@lts-rad commented on GitHub (May 10, 2024):
the dns override at least has it, so im thinking maybe it didnt make it to the log settings previously
@lts-rad commented on GitHub (Aug 1, 2024):
is this resolved now? as of v0.3.14
@0vercl0k commented on GitHub (Aug 4, 2024):
This is fixed in the DNS override view yes, but it isn't fixed in the 'DNS Log > Log Settings > Host Privacy IP List' view (same on v0.3.14 as well).
Cheers
@0vercl0k commented on GitHub (Jan 7, 2025):
Bumping this as this is still an issue on latest v1.0.4!
Cheers