[GH-ISSUE #297] merge rebinding protection and block plugin #130

New issue

Closed

opened 2026-03-04 01:35:02 +03:00 by kerem · 2 comments

kerem commented

2026-03-04 01:35:02 +03:00

Owner

Originally created by @lts-rad on GitHub (Mar 13, 2024).
Original GitHub issue: https://github.com/spr-networks/super/issues/297

Originally assigned to: @lts-rad on GitHub.

right now an override does not allow an ip under rebinding protection to be permitted. this is not intuitive behavior.

to fix this, the rebinding plugin will be merged into the block plugin.

old behavior:

domain override says yes
rebinding happens next. does not know about override, blocks domain

new behavior:

ui to enable/disable rebinding check under dns settings
when a permit override happens, the rebinding check will not happen.

Originally created by @lts-rad on GitHub (Mar 13, 2024). Original GitHub issue: https://github.com/spr-networks/super/issues/297 Originally assigned to: @lts-rad on GitHub. right now an override does not allow an ip under rebinding protection to be permitted. this is not intuitive behavior. to fix this, the rebinding plugin will be merged into the block plugin. old behavior: - domain override says yes - rebinding happens next. does not know about override, blocks domain new behavior: - ui to enable/disable rebinding check under dns settings - when a permit override happens, the rebinding check will not happen.

kerem

2026-03-04 01:35:02 +03:00

closed this issue
added the
bug

enhancement
labels

kerem commented

2026-03-04 01:35:03 +03:00

Author

Owner

@lts-rad commented on GitHub (Mar 13, 2024):

another pain point is the https://coredns.io/plugins/cache/ plugin versus block.

right now it will cache with NXDOMAIN.

looking at the docs, https://coredns.io/plugins/cache/

there is an option to not cache SERVFAIL. but we return NXDOMAIN instead so cant leverage it. doesnt seem like any straight fordard way to evict from cache. one option is to fork the cache plugin and use our own fork for this purpose, and then try to merge the changes upstream.

@lts-rad commented on GitHub (Mar 13, 2024): another pain point is the https://coredns.io/plugins/cache/ plugin versus block. right now it will cache with NXDOMAIN. looking at the docs, https://coredns.io/plugins/cache/ there is an option to not cache SERVFAIL. but we return NXDOMAIN instead so cant leverage it. doesnt seem like any straight fordard way to evict from cache. one option is to fork the cache plugin and use our own fork for this purpose, and then try to merge the changes upstream.

kerem commented

2026-03-04 01:35:03 +03:00

Author

Owner

@lts-rad commented on GitHub (Mar 13, 2024):

this is now in the dev branch

@lts-rad commented on GitHub (Mar 13, 2024): this is now in the dev branch

kerem referenced this issue

2026-03-04 01:36:21 +03:00

[PR #130] [MERGED] update GitHub Actions #337