starred/super

Fork 0

mirror of https://github.com/spr-networks/super.git synced 2026-04-25 04:45:51 +03:00

[GH-ISSUE #282] device expiry time calculation seems broken in UI #119

New issue

Closed

opened 2026-03-04 01:34:56 +03:00 by kerem · 9 comments

kerem commented

2026-03-04 01:34:56 +03:00

Owner

Originally created by @lts-rad on GitHub (Feb 7, 2024).
Original GitHub issue: https://github.com/spr-networks/super/issues/282

Originally assigned to: @lts-rad on GitHub.

Originally created by @lts-rad on GitHub (Feb 7, 2024). Original GitHub issue: https://github.com/spr-networks/super/issues/282 Originally assigned to: @lts-rad on GitHub.

kerem closed this issue

2026-03-04 01:34:56 +03:00

kerem commented

2026-03-04 01:34:57 +03:00

Author

Owner

@lts-rad commented on GitHub (Feb 8, 2024):

@0vercl0k i have not been able to reproduce this yet

@lts-rad commented on GitHub (Feb 8, 2024): @0vercl0k i have not been able to reproduce this yet

kerem commented

2026-03-04 01:34:57 +03:00

Author

Owner

@lts-rad commented on GitHub (Feb 8, 2024):

need to test closer to 0 GMT in case this is a bug with the timeAgo.js package

@lts-rad commented on GitHub (Feb 8, 2024): need to test closer to 0 GMT in case this is a bug with the timeAgo.js package

kerem commented

2026-03-04 01:34:57 +03:00

Author

Owner

@lts-rad commented on GitHub (Feb 8, 2024):

smells like https://github.com/hustcc/timeago.js/issues/222

@lts-rad commented on GitHub (Feb 8, 2024): smells like https://github.com/hustcc/timeago.js/issues/222

kerem commented

2026-03-04 01:34:57 +03:00

Author

Owner

@0vercl0k commented on GitHub (Feb 8, 2024):

i'm happy to try to repro again or help in any way :) Give me a shout!

On Thu, Feb 8, 2024 at 10:50 AM Alex Rad @.***> wrote:

smells like hustcc/timeago.js#222
https://github.com/hustcc/timeago.js/issues/222

—
Reply to this email directly, view it on GitHub
https://github.com/spr-networks/super/issues/282#issuecomment-1934739871,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALIORPFF27JQXHBGO2L4YLYSUM77AVCNFSM6AAAAABC5BM746VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUG4ZTSOBXGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

@0vercl0k commented on GitHub (Feb 8, 2024): i'm happy to try to repro again or help in any way :) Give me a shout! On Thu, Feb 8, 2024 at 10:50 AM Alex Rad ***@***.***> wrote: > smells like hustcc/timeago.js#222 > <https://github.com/hustcc/timeago.js/issues/222> > > — > Reply to this email directly, view it on GitHub > <https://github.com/spr-networks/super/issues/282#issuecomment-1934739871>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AALIORPFF27JQXHBGO2L4YLYSUM77AVCNFSM6AAAAABC5BM746VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUG4ZTSOBXGE> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

kerem commented

2026-03-04 01:34:57 +03:00

Author

Owner

@lts-rad commented on GitHub (Feb 8, 2024):

Expire in ${timeAgo(
    new Date('07 Feb 2024 03:39:31 GMT').toUTCString()
  , 'en_US', {relativeDate: '07 Feb 2024 02:26:31 GMT'})}

correctly reports 1 hour at least

@lts-rad commented on GitHub (Feb 8, 2024): Expire in ${timeAgo( new Date('07 Feb 2024 03:39:31 GMT').toUTCString() , 'en_US', {relativeDate: '07 Feb 2024 02:26:31 GMT'})} correctly reports 1 hour at least

kerem commented

2026-03-04 01:34:57 +03:00

Author

Owner

@lts-rad commented on GitHub (Feb 8, 2024):

seems like the issue is not with the rendering. perhaps a UI state error with inputting the wrong time

@lts-rad commented on GitHub (Feb 8, 2024): seems like the issue is not with the rendering. perhaps a UI state error with inputting the wrong time

kerem commented

2026-03-04 01:34:58 +03:00

Author

Owner

@0vercl0k commented on GitHub (Feb 8, 2024):

I can still repro this on latest flights fwiw

On Thu, Feb 8, 2024 at 12:04 PM Alex Rad @.***> wrote:

seems like the issue is not with the rendering. perhaps a UI state error
with inputting the wrong time

—
Reply to this email directly, view it on GitHub
https://github.com/spr-networks/super/issues/282#issuecomment-1934850596,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALIOROJ5MFVOEJMBPIXHBLYSUVTLAVCNFSM6AAAAABC5BM746VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUHA2TANJZGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

@0vercl0k commented on GitHub (Feb 8, 2024): I can still repro this on latest flights fwiw On Thu, Feb 8, 2024 at 12:04 PM Alex Rad ***@***.***> wrote: > seems like the issue is not with the rendering. perhaps a UI state error > with inputting the wrong time > > — > Reply to this email directly, view it on GitHub > <https://github.com/spr-networks/super/issues/282#issuecomment-1934850596>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AALIOROJ5MFVOEJMBPIXHBLYSUVTLAVCNFSM6AAAAABC5BM746VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUHA2TANJZGY> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

kerem commented

2026-03-04 01:34:58 +03:00

Author

Owner

@lts-po commented on GitHub (Feb 9, 2024):

@0vercl0k think its related to editing a pending device, does it work ok when editing a device that is not pending / after its auth'd? pushing a fix that will handle this for pending devices

@lts-po commented on GitHub (Feb 9, 2024): @0vercl0k think its related to editing a pending device, does it work ok when editing a device that is not pending / after its auth'd? pushing a fix that will handle this for pending devices

kerem commented

2026-03-04 01:34:58 +03:00

Author

Owner

@0vercl0k commented on GitHub (Feb 9, 2024):

I've just tried it out - it seems the UI behaves the same way if I connect
a device "Expire in 8 minute ago". But the device actually doesn't seem to
be auto removed so maybe it's just a UI display issue?

On Fri, Feb 9, 2024 at 4:19 AM lts-po @.***> wrote:

@0vercl0k https://github.com/0vercl0k think its related to editing a
pending device, does it work ok when editing a device that is not pending /
after its auth'd? pushing a fix that will handle this for pending devices

—
Reply to this email directly, view it on GitHub
https://github.com/spr-networks/super/issues/282#issuecomment-1935830703,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALIORJYVTXYMGDZ55DKIULYSYH6FAVCNFSM6AAAAABC5BM746VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZVHAZTANZQGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

@0vercl0k commented on GitHub (Feb 9, 2024): I've just tried it out - it seems the UI behaves the same way if I connect a device "Expire in 8 minute ago". But the device actually doesn't seem to be auto removed so maybe it's just a UI display issue? On Fri, Feb 9, 2024 at 4:19 AM lts-po ***@***.***> wrote: > @0vercl0k <https://github.com/0vercl0k> think its related to editing a > pending device, does it work ok when editing a device that is not pending / > after its auth'd? pushing a fix that will handle this for pending devices > > — > Reply to this email directly, view it on GitHub > <https://github.com/spr-networks/super/issues/282#issuecomment-1935830703>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AALIORJYVTXYMGDZ55DKIULYSYH6FAVCNFSM6AAAAABC5BM746VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZVHAZTANZQGM> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

kerem referenced this issue

2026-03-04 01:36:18 +03:00

[PR #119] [MERGED] [build] Update dev channel #327