[PR #682] [MERGED] Set cache checking to false so that failing test passes #994

Closed
opened 2026-02-28 00:03:09 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/spotipy-dev/spotipy/pull/682
Author: @gustavokrieger
Created: 4/24/2021
Status: Merged
Merged: 4/25/2021
Merged by: @stephanebruckert

Base: masterHead: remove-cache-check-in-failing-test


📝 Commits (1)

  • 25616e5 set cache checking to false so that failing test passes

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 tests/unit/test_oauth.py (+1 -1)

📄 Description

The SpotifyOauthError wasn't being raised when I ran the test. I found out that it was happening because it was using a cached valid token, intead of the authentication that was supposed to fail. Removed cache checking in the test.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/spotipy-dev/spotipy/pull/682 **Author:** [@gustavokrieger](https://github.com/gustavokrieger) **Created:** 4/24/2021 **Status:** ✅ Merged **Merged:** 4/25/2021 **Merged by:** [@stephanebruckert](https://github.com/stephanebruckert) **Base:** `master` ← **Head:** `remove-cache-check-in-failing-test` --- ### 📝 Commits (1) - [`25616e5`](https://github.com/spotipy-dev/spotipy/commit/25616e51a5fcd95fb2e5fc92ca9921ad6bc7b40d) set cache checking to false so that failing test passes ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `tests/unit/test_oauth.py` (+1 -1) </details> ### 📄 Description The `SpotifyOauthError` wasn't being raised when I ran the test. I found out that it was happening because it was using a cached valid token, intead of the authentication that was supposed to fail. Removed cache checking in the test. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:03:09 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotipy#994
No description provided.