mirror of
https://github.com/spotipy-dev/spotipy.git
synced 2026-04-27 00:25:54 +03:00
[PR #636] [MERGED] Removed requirement for examples/app.py to specify port multiple times (only SPOTIPY_REDIRECT_URI needs to contain the port) #971
Labels
No labels
api-bug
bug
dependencies
documentation
duplicate
enhancement
external-ide
headless-mode
implicit-grant-flow
invalid
missing-endpoint
pr-welcome
private-api
pull-request
question
spotipy3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotipy#971
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/spotipy-dev/spotipy/pull/636
Author: @AlexCherrypi
Created: 1/30/2021
Status: ✅ Merged
Merged: 1/30/2021
Merged by: @stephanebruckert
Base:
master← Head:patch-1📝 Commits (9)
7f94283pull port from SPOTIPY_REDIRECT_URI rather than having to specify itas --port4f1b634keep legacy PORT envar support.6015373added app.py changes to CHANGELOGc03287dadding forgotten bracketdb05ff9added end of line- requirement to regex for good measuree2c6f7dfix indentationf2aa957Readability and requested changesad5fb12remove re dependency as we don't need it anymore359798dSimplify the port selection for app.run📊 Changes
2 files changed (+4 additions, -2 deletions)
View changed files
📝
CHANGELOG.md(+1 -0)📝
examples/app.py(+3 -2)📄 Description
we try to get the port from SPOTIPY_REDIRECT_URI as we already have to set it there anyway.
if we don't succeed we use 8080 as fallback.
for legacy compatibility we still allow PORT envar and let it override the setting
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.