mirror of
https://github.com/spotipy-dev/spotipy.git
synced 2026-04-27 00:25:54 +03:00
[PR #590] [CLOSED] Default Script-based Configurations is set for Logging #953
Labels
No labels
api-bug
bug
dependencies
documentation
duplicate
enhancement
external-ide
headless-mode
implicit-grant-flow
invalid
missing-endpoint
pr-welcome
private-api
pull-request
question
spotipy3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotipy#953
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/spotipy-dev/spotipy/pull/590
Author: @lnxpy
Created: 10/20/2020
Status: ❌ Closed
Base:
master← Head:master📝 Commits (3)
5074495base configs addedb63931e--user flag removed in the installation3a0bf5dupdate📊 Changes
3 files changed (+13 additions, -3 deletions)
View changed files
📝
CHANGELOG.md(+6 -2)📝
CONTRIBUTING.md(+1 -1)📝
spotipy/util.py(+6 -0)📄 Description
In most cases, It's better to create a base configuration for
loggingwhich is easily available on structlog too. Not a big difference to either use a YML, or a JSON based method for configurations. Most often we use the external methods when we are trying to focus on the logging side. Base configurations allow you to override the original classes and have your own configurations.Changes
CHANGELOG.mdfile ~ "Unreleased" section: Subsections are sorted alphabetically and the new changes and adds are explained.CONTRIBUTING.mdfile ~ "Create virtual environment" section: When you create a virtual environment, there is no need to use--userflag in the installation process. In some cases, it might break the installation cycle. Packages are being installed in the virtual environment by default, but if you use--user, it will force it to install outside the virtual environments.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.