[PR #583] [MERGED] Fixed UnboundLocalError / AttributeError #571, #581 #951

Closed
opened 2026-02-28 00:02:52 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/spotipy-dev/spotipy/pull/583
Author: @Quizz1Cal
Created: 10/6/2020
Status: Merged
Merged: 10/7/2020
Merged by: @stephanebruckert

Base: masterHead: fix581


📝 Commits (4)

📊 Changes

3 files changed (+27 additions, -5 deletions)

View changed files

📝 CHANGELOG.md (+3 -1)
📝 spotipy/client.py (+10 -4)
📝 tests/integration/test_non_user_endpoints.py (+14 -0)

📄 Description

Have also added an integration test to confirm that when max entries is reached, SpotifyException is thrown, and not the unexpected errors noted in issues #571 and #581.

Fixes #571 and #581.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/spotipy-dev/spotipy/pull/583 **Author:** [@Quizz1Cal](https://github.com/Quizz1Cal) **Created:** 10/6/2020 **Status:** ✅ Merged **Merged:** 10/7/2020 **Merged by:** [@stephanebruckert](https://github.com/stephanebruckert) **Base:** `master` ← **Head:** `fix581` --- ### 📝 Commits (4) - [`a83fa4c`](https://github.com/spotipy-dev/spotipy/commit/a83fa4c630d2197e357b309623e4a90659dbfe31) Fix plamere/spotipy#571, plamere/spotipy#581 - [`83c99e1`](https://github.com/spotipy-dev/spotipy/commit/83c99e1ab5ae82906e43d28ebafb6c76b522078e) Add integration test for reaching max retries - [`51b8d1b`](https://github.com/spotipy-dev/spotipy/commit/51b8d1b0f7b29a1c4e61f25f7a2136f0cb0b46d9) Update tests/integration/test_non_user_endpoints.py - [`f4585d6`](https://github.com/spotipy-dev/spotipy/commit/f4585d6fd89ef89cbddde4eb07b7baad8a7c40fb) Update CHANGELOG.md, integration test mock data ### 📊 Changes **3 files changed** (+27 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+3 -1) 📝 `spotipy/client.py` (+10 -4) 📝 `tests/integration/test_non_user_endpoints.py` (+14 -0) </details> ### 📄 Description Have also added an integration test to confirm that when max entries is reached, SpotifyException is thrown, and not the unexpected errors noted in issues #571 and #581. Fixes #571 and #581. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:02:52 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotipy#951
No description provided.