mirror of
https://github.com/spotipy-dev/spotipy.git
synced 2026-04-27 00:25:54 +03:00
[PR #567] [MERGED] Made cache_path and username optional #945
Labels
No labels
api-bug
bug
dependencies
documentation
duplicate
enhancement
external-ide
headless-mode
implicit-grant-flow
invalid
missing-endpoint
pr-welcome
private-api
pull-request
question
spotipy3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotipy#945
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/spotipy-dev/spotipy/pull/567
Author: @stephanebruckert
Created: 8/30/2020
Status: ✅ Merged
Merged: 8/30/2020
Merged by: @stephanebruckert
Base:
master← Head:empty-username📝 Commits (5)
be10d57Made cache_path and username optional3979701Update readme and example983d57cLint2709eaeLint1b45e8eFeedback / add warning📊 Changes
9 files changed (+128 additions, -139 deletions)
View changed files
📝
CHANGELOG.md(+4 -0)📝
README.md(+0 -1)📝
examples/my_top_tracks.py(+0 -8)📝
examples/remove_specific_tracks_from_playlist.py(+1 -1)📝
examples/replace_tracks_in_playlist.py(+1 -1)📝
examples/show_user.py(+1 -2)📝
spotipy/oauth2.py(+109 -113)📝
spotipy/util.py(+10 -11)📝
tests/unit/test_oauth.py(+2 -2)📄 Description
As suggested here https://github.com/plamere/spotipy/issues/533#issuecomment-682304023
The API itself does not require a username but Spotipy was still asking for it in order to know where to store the token.
I think most devs want to get started quickly and will by default only use their main account, so storing that main account token in a cache called
.cacheshould be fine.Apps that specify a username should still work.
Fixes https://github.com/plamere/spotipy/issues/507, https://github.com/plamere/spotipy/issues/512, https://github.com/plamere/spotipy/issues/549
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.