mirror of
https://github.com/spotipy-dev/spotipy.git
synced 2026-04-26 16:15:51 +03:00
[PR #559] [MERGED] Fix playlist add items #939
Labels
No labels
api-bug
bug
dependencies
documentation
duplicate
enhancement
external-ide
headless-mode
implicit-grant-flow
invalid
missing-endpoint
pr-welcome
private-api
pull-request
question
spotipy3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotipy#939
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/spotipy-dev/spotipy/pull/559
Author: @plamere
Created: 8/24/2020
Status: ✅ Merged
Merged: 8/25/2020
Merged by: @stephanebruckert
Base:
master← Head:fix_playlist_add_items📝 Commits (4)
41380aefixed uri issue in playlist_add_itemse23aa8eAdded tests for episode adds8cc3562Fixed creep_url to match creep_uri2c81725revert pip version, added FIX to changelog📊 Changes
4 files changed (+40 additions, -4 deletions)
View changed files
📝
CHANGELOG.md(+3 -0)📝
spotipy/client.py(+7 -1)📝
tests/integration/test_non_user_endpoints.py(+3 -3)📝
tests/integration/test_user_endpoints.py(+27 -0)📄 Description
The playlist_add_items method did not work if the given items were episodes. This was because all uris were being converted to track uris. I've changed this so that URIs are no longer automatically converted to track uris.
Also, in the unittests, the track uris and ids for 'Creep' were old causing the 'popularity' test to fail. I changed the URI to a more recent one to fix the tests.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.