[PR #559] [MERGED] Fix playlist add items #939

Closed
opened 2026-02-28 00:02:46 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/spotipy-dev/spotipy/pull/559
Author: @plamere
Created: 8/24/2020
Status: Merged
Merged: 8/25/2020
Merged by: @stephanebruckert

Base: masterHead: fix_playlist_add_items


📝 Commits (4)

  • 41380ae fixed uri issue in playlist_add_items
  • e23aa8e Added tests for episode adds
  • 8cc3562 Fixed creep_url to match creep_uri
  • 2c81725 revert pip version, added FIX to changelog

📊 Changes

4 files changed (+40 additions, -4 deletions)

View changed files

📝 CHANGELOG.md (+3 -0)
📝 spotipy/client.py (+7 -1)
📝 tests/integration/test_non_user_endpoints.py (+3 -3)
📝 tests/integration/test_user_endpoints.py (+27 -0)

📄 Description

The playlist_add_items method did not work if the given items were episodes. This was because all uris were being converted to track uris. I've changed this so that URIs are no longer automatically converted to track uris.

Also, in the unittests, the track uris and ids for 'Creep' were old causing the 'popularity' test to fail. I changed the URI to a more recent one to fix the tests.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/spotipy-dev/spotipy/pull/559 **Author:** [@plamere](https://github.com/plamere) **Created:** 8/24/2020 **Status:** ✅ Merged **Merged:** 8/25/2020 **Merged by:** [@stephanebruckert](https://github.com/stephanebruckert) **Base:** `master` ← **Head:** `fix_playlist_add_items` --- ### 📝 Commits (4) - [`41380ae`](https://github.com/spotipy-dev/spotipy/commit/41380ae4f48566ce274a5ef36ccfab98fc5c1697) fixed uri issue in playlist_add_items - [`e23aa8e`](https://github.com/spotipy-dev/spotipy/commit/e23aa8e03cd356f114d0f18a2577b4d25b0d8952) Added tests for episode adds - [`8cc3562`](https://github.com/spotipy-dev/spotipy/commit/8cc356238012858a32fce58606b3ec18ccb29154) Fixed creep_url to match creep_uri - [`2c81725`](https://github.com/spotipy-dev/spotipy/commit/2c81725b4b1e7b14a358e9448786e03bb3b22f63) revert pip version, added FIX to changelog ### 📊 Changes **4 files changed** (+40 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+3 -0) 📝 `spotipy/client.py` (+7 -1) 📝 `tests/integration/test_non_user_endpoints.py` (+3 -3) 📝 `tests/integration/test_user_endpoints.py` (+27 -0) </details> ### 📄 Description The playlist_add_items method did not work if the given items were episodes. This was because all uris were being converted to track uris. I've changed this so that URIs are no longer automatically converted to track uris. Also, in the unittests, the track uris and ids for 'Creep' were old causing the 'popularity' test to fail. I changed the URI to a more recent one to fix the tests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:02:46 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotipy#939
No description provided.