mirror of
https://github.com/spotipy-dev/spotipy.git
synced 2026-04-26 16:15:51 +03:00
[PR #542] [MERGED] Adding Initial PKCE Auth Flow Support #931
Labels
No labels
api-bug
bug
dependencies
documentation
duplicate
enhancement
external-ide
headless-mode
implicit-grant-flow
invalid
missing-endpoint
pr-welcome
private-api
pull-request
question
spotipy3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotipy#931
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/spotipy-dev/spotipy/pull/542
Author: @DJSdev
Created: 7/14/2020
Status: ✅ Merged
Merged: 7/21/2020
Merged by: @stephanebruckert
Base:
master← Head:djsdev/SpotifyPKCE📝 Commits (10+)
9fa90d2Added base funtionality for PKCE Authorization - i538323b330fixed a mistake with the auth code7b798a5fixed more misunderstandings. fixed grant_access_token to now call authorization if needed61a5634added comments and references to code verifier and code challenge5810530removed debug print statement49a2e0fupdated unit tests for new PKCE flow4a6cee3cleaned up username issues - added doc strings to class9473d08fixed import issue, added user endpoint tests3fec740forgot to commit this file6293b8alinted📊 Changes
4 files changed (+531 additions, -2 deletions)
View changed files
📝
CHANGELOG.md(+1 -0)📝
spotipy/oauth2.py(+358 -0)📝
tests/integration/test_user_endpoints.py(+35 -1)📝
tests/unit/test_oauth.py(+137 -1)📄 Description
Adds functionality for the PKCE Authorization Flow. This is now the preferred method for developers to integrate desktops and mobile applications with the Spotify API.
The benefits include:
Requested in #538 - Sorry if I jumped the gun adding this functionality without commenting on the enhancement request/issue. I needed this functionality for an app I'm working on and saw the recent enhancement request for so decided to work on it.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.