mirror of
https://github.com/spotipy-dev/spotipy.git
synced 2026-04-27 08:35:49 +03:00
[PR #435] [MERGED] Auto-refresh AuthCode flow token. #894
Labels
No labels
api-bug
bug
dependencies
documentation
duplicate
enhancement
external-ide
headless-mode
implicit-grant-flow
invalid
missing-endpoint
pr-welcome
private-api
pull-request
question
spotipy3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotipy#894
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/spotipy-dev/spotipy/pull/435
Author: @stefanondisponibile
Created: 2/3/2020
Status: ✅ Merged
Merged: 2/10/2020
Merged by: @stephanebruckert
Base:
master← Head:master📝 Commits (10+)
1a2d3f7Auto-refresh AuthCode flow token.0531af3Reformatted.039863bReformatted.1245c50Removed invalid syntax.c42ea02Removed abstract class SpotifyAuthManager.3586b4cFix typo on docstrings.ad5dd25Optionally try to fetch main input parameters from environment.f810086Removed f-string for Python2 compatibility.1f6dc17Fix line-too-long.b0b2841Remove useless import.📊 Changes
5 files changed (+723 additions, -445 deletions)
View changed files
📝
CHANGELOG.md(+7 -0)➕
examples/simple4.py(+12 -0)📝
spotipy/client.py(+441 -296)📝
spotipy/oauth2.py(+210 -83)📝
spotipy/util.py(+53 -66)📄 Description
I loved @stephanebruckert 's idea of having similar handlers for the two different authorization flows.
I think it would be even better having one one unique
auth_managerinside theSpotifyclient, and infer it from the parameters. This also would allow a smooth and backward compatible pass to this.What do you think?
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.