starred/spotipy
1
0
Fork 0
mirror of https://github.com/spotipy-dev/spotipy.git synced 2026-04-27 00:25:54 +03:00
Code Issues 62 Projects Releases 10 Packages Wiki Activity

[PR #414] [MERGED] Harrison97 fork progress #883

New issue
Closed
opened 2026-02-28 00:02:21 +03:00 by kerem · 0 comments
kerem commented 2026-02-28 00:02:21 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/spotipy-dev/spotipy/pull/414
Author: @stephanebruckert
Created: 1/11/2020
Status: ✅ Merged
Merged: 1/11/2020
Merged by: @stephanebruckert

Base: master ← Head: main-fork-progress

📝 Commits (10+)

📊 Changes

42 files changed (+799 additions, -527 deletions)

View changed files

📝 .gitignore (+1 -2)
➕ CHANGELOG.md (+37 -0)
➖ CHANGES.txt (+0 -16)
📝 README.md (+1 -34)
📝 deploy (+3 -4)
📝 docs/index.rst (+54 -47)
📝 examples/artist_discography.py (+1 -1)
📝 examples/contains_a_saved_track.py (+1 -1)
📝 examples/my_playlists.py (+1 -1)
📝 examples/my_top_artists.py (+3 -3)
📝 examples/my_top_tracks.py (+5 -5)
📝 examples/read_a_playlist.py (+1 -1)
📝 examples/remove_specific_tracks_from_playlist.py (+1 -2)
📝 examples/remove_tracks_from_playlist.py (+1 -2)
📝 examples/replace_tracks_in_playlist.py (+0 -1)
📝 examples/show_album.py (+3 -1)
📝 examples/show_artist.py (+3 -1)
📝 examples/show_artist_top_tracks.py (+3 -1)
📝 examples/show_related.py (+4 -1)
📝 examples/show_track_info.py (+3 -1)

...and 22 more files

📄 Description

Taking everything from https://github.com/Harrison97/spotipy-plamere/

New endpoints:

  • get_playlist by id and without user
  • current_user_saved_albums_delete
  • current_user_saved_albums_contains
  • user_unfollow_artists
  • user_unfollow_users

Integration tests passing locally for python2.7 and python3.7.5

✗ python3 -m unittest discover -v tests
test_basic_user_profile (test_auth.AuthTestSpotipy) ... ok
test_categories (test_auth.AuthTestSpotipy) ... ok
test_category_playlists (test_auth.AuthTestSpotipy) ... ok
test_current_user (test_auth.AuthTestSpotipy) ... ok
test_current_user_follows (test_auth.AuthTestSpotipy) ... ok
test_current_user_playlists (test_auth.AuthTestSpotipy) ... ok
test_current_user_save_and_unsave_tracks (test_auth.AuthTestSpotipy) ... ok
test_current_user_saved_albums (test_auth.AuthTestSpotipy) ... ok
test_current_user_saved_tracks (test_auth.AuthTestSpotipy) ... ok
test_current_user_top_artists (test_auth.AuthTestSpotipy) ... ok
test_current_user_top_tracks (test_auth.AuthTestSpotipy) ... ok
test_featured_releases (test_auth.AuthTestSpotipy) ... ok
test_me (test_auth.AuthTestSpotipy) ... ok
test_new_releases (test_auth.AuthTestSpotipy) ... ok
test_playlist (test_auth.AuthTestSpotipy) ... ok
test_track_bad_id (test_auth.AuthTestSpotipy) ... ok
test_user_follows_and_unfollows_artist (test_auth.AuthTestSpotipy) ... ok
test_user_follows_and_unfollows_user (test_auth.AuthTestSpotipy) ... ok
test_user_playlist_follow (test_auth.AuthTestSpotipy) ... ok
test_user_playlist_ops (test_auth.AuthTestSpotipy) ... ok
test_user_playlist_tracks (test_auth.AuthTestSpotipy) ... ok
test_user_playlists (test_auth.AuthTestSpotipy) ... ok
test_audio_analysis (test_auth2.AuthTestSpotipy) ... ok
test_audio_features (test_auth2.AuthTestSpotipy) ... ok
test_audio_features_with_bad_track (test_auth2.AuthTestSpotipy) ... ok
test_recommendations (test_auth2.AuthTestSpotipy) ... ok
test_request_with_token (test_client_credentials.ClientCredentialsTestSpotipy) ... ok
test_badly_scoped_token_bails (test_oauth.OAuthCacheTest) ... ok
test_expired_token_refreshes (test_oauth.OAuthCacheTest) ... ok
test_gets_from_cache_path (test_oauth.OAuthCacheTest) ... ok
test_saves_to_cache_path (test_oauth.OAuthCacheTest) ... ok
test_get_authorize_url_does_not_show_dialog_by_default (test_oauth.TestSpotifyOAuth) ... ok
test_get_authorize_url_doesnt_pass_state_by_default (test_oauth.TestSpotifyOAuth) ... ok
test_get_authorize_url_passes_state_from_constructor (test_oauth.TestSpotifyOAuth) ... ok
test_get_authorize_url_passes_state_from_func_call (test_oauth.TestSpotifyOAuth) ... ok
test_get_authorize_url_shows_dialog_when_requested (test_oauth.TestSpotifyOAuth) ... ok
test_album_search (tests.TestSpotipy) ... ok
test_album_tracks (tests.TestSpotipy) ... ok
test_album_tracks_many (tests.TestSpotipy) ... ok
test_album_urn (tests.TestSpotipy) ... ok
test_albums (tests.TestSpotipy) ... ok
test_artist_albums (tests.TestSpotipy) ... ok
test_artist_related_artists (tests.TestSpotipy) ... ok
test_artist_search (tests.TestSpotipy) ... ok
test_artist_search_with_market (tests.TestSpotipy) ... ok
test_artist_top_tracks (tests.TestSpotipy) ... ok
test_artist_urn (tests.TestSpotipy) ... ok
test_artists (tests.TestSpotipy) ... ok
test_custom_requests_session (tests.TestSpotipy) ... ok
test_force_no_requests_session (tests.TestSpotipy) ... ok
test_search_timeout (tests.TestSpotipy) ... ok
test_track_bad_id (tests.TestSpotipy) ... ok
test_track_bad_urn (tests.TestSpotipy) ... ok
test_track_id (tests.TestSpotipy) ... ok
test_track_search (tests.TestSpotipy) ... ok
test_track_url (tests.TestSpotipy) ... ok
test_track_urn (tests.TestSpotipy) ... ok
test_tracks (tests.TestSpotipy) ... ok
test_unauthenticated_post_fails (tests.TestSpotipy) ... ok
test_user (tests.TestSpotipy) ... ok

----------------------------------------------------------------------
Ran 60 tests in 69.277s

OK

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/spotipy-dev/spotipy/pull/414 **Author:** [@stephanebruckert](https://github.com/stephanebruckert) **Created:** 1/11/2020 **Status:** ✅ Merged **Merged:** 1/11/2020 **Merged by:** [@stephanebruckert](https://github.com/stephanebruckert) **Base:** `master` ← **Head:** `main-fork-progress` --- ### 📝 Commits (10+) - [`e1ba4a9`](https://github.com/spotipy-dev/spotipy/commit/e1ba4a9bbb2a50804581325c023d64fe06a6c94f) Re-order imports and specify UTF-8 encoding header in all base modules and package initialiser (ref. https://www.python.org/dev/peps/pep-0008/#imports, https://www.python.org/dev/peps/pep-0008/#source-file-encoding) + add `__all__` attribute - [`ef49cd6`](https://github.com/spotipy-dev/spotipy/commit/ef49cd6e039f7b65942871226461bc7ccce13f26) Update spotify package initialiser - [`502a56f`](https://github.com/spotipy-dev/spotipy/commit/502a56f98713bcb8415e7f6e742160b012863790) Remove relative imports in `spotify` package initialiser - [`e9edf2a`](https://github.com/spotipy-dev/spotipy/commit/e9edf2a255f0e9ffa8fde02a09bad0282eae989a) Miscellaneous fixes - clean up tests - [`6639a98`](https://github.com/spotipy-dev/spotipy/commit/6639a98e24b87cf0f9d470050cc3d00ecd2fbb91) Further clean up of tests - [`e5ccb9f`](https://github.com/spotipy-dev/spotipy/commit/e5ccb9f35511813ba4514b9654bcff346ac54b51) Renaming some test modules: `authtests.py` -> `test_auth.py`, `authtests2.py` -> `test_auth2.py`, `client_credential_tests.py` -> `test_client_credentials.py` + update `tox.ini` - [`2ce2705`](https://github.com/spotipy-dev/spotipy/commit/2ce270554ad503390bcb6c15ce6eab38bf8ecbcb) Update tests - make client credentials env. vars list a commonly accessible dictionary in `spotipy/util.py` - [`9d88a68`](https://github.com/spotipy-dev/spotipy/commit/9d88a68d50bb5a76ebd747e11734428d49112f03) Update client.py (add playlist endpoint) - [`f872f5b`](https://github.com/spotipy-dev/spotipy/commit/f872f5b90c6b91e05ac72b8cf4b75fd6eaac05ed) Minor docs fix - [`469fbf1`](https://github.com/spotipy-dev/spotipy/commit/469fbf1b1e5ed4534fdcf8fea40ec77a17eadef0) Fixed docstring error ### 📊 Changes **42 files changed** (+799 additions, -527 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -2) ➕ `CHANGELOG.md` (+37 -0) ➖ `CHANGES.txt` (+0 -16) 📝 `README.md` (+1 -34) 📝 `deploy` (+3 -4) 📝 `docs/index.rst` (+54 -47) 📝 `examples/artist_discography.py` (+1 -1) 📝 `examples/contains_a_saved_track.py` (+1 -1) 📝 `examples/my_playlists.py` (+1 -1) 📝 `examples/my_top_artists.py` (+3 -3) 📝 `examples/my_top_tracks.py` (+5 -5) 📝 `examples/read_a_playlist.py` (+1 -1) 📝 `examples/remove_specific_tracks_from_playlist.py` (+1 -2) 📝 `examples/remove_tracks_from_playlist.py` (+1 -2) 📝 `examples/replace_tracks_in_playlist.py` (+0 -1) 📝 `examples/show_album.py` (+3 -1) 📝 `examples/show_artist.py` (+3 -1) 📝 `examples/show_artist_top_tracks.py` (+3 -1) 📝 `examples/show_related.py` (+4 -1) 📝 `examples/show_track_info.py` (+3 -1) _...and 22 more files_ </details> ### 📄 Description Taking everything from https://github.com/Harrison97/spotipy-plamere/ New endpoints: - [x] get_playlist by id and without user - [x] current_user_saved_albums_delete - [x] current_user_saved_albums_contains - [x] user_unfollow_artists - [x] user_unfollow_users Integration tests passing locally for python2.7 and python3.7.5 ``` ✗ python3 -m unittest discover -v tests test_basic_user_profile (test_auth.AuthTestSpotipy) ... ok test_categories (test_auth.AuthTestSpotipy) ... ok test_category_playlists (test_auth.AuthTestSpotipy) ... ok test_current_user (test_auth.AuthTestSpotipy) ... ok test_current_user_follows (test_auth.AuthTestSpotipy) ... ok test_current_user_playlists (test_auth.AuthTestSpotipy) ... ok test_current_user_save_and_unsave_tracks (test_auth.AuthTestSpotipy) ... ok test_current_user_saved_albums (test_auth.AuthTestSpotipy) ... ok test_current_user_saved_tracks (test_auth.AuthTestSpotipy) ... ok test_current_user_top_artists (test_auth.AuthTestSpotipy) ... ok test_current_user_top_tracks (test_auth.AuthTestSpotipy) ... ok test_featured_releases (test_auth.AuthTestSpotipy) ... ok test_me (test_auth.AuthTestSpotipy) ... ok test_new_releases (test_auth.AuthTestSpotipy) ... ok test_playlist (test_auth.AuthTestSpotipy) ... ok test_track_bad_id (test_auth.AuthTestSpotipy) ... ok test_user_follows_and_unfollows_artist (test_auth.AuthTestSpotipy) ... ok test_user_follows_and_unfollows_user (test_auth.AuthTestSpotipy) ... ok test_user_playlist_follow (test_auth.AuthTestSpotipy) ... ok test_user_playlist_ops (test_auth.AuthTestSpotipy) ... ok test_user_playlist_tracks (test_auth.AuthTestSpotipy) ... ok test_user_playlists (test_auth.AuthTestSpotipy) ... ok test_audio_analysis (test_auth2.AuthTestSpotipy) ... ok test_audio_features (test_auth2.AuthTestSpotipy) ... ok test_audio_features_with_bad_track (test_auth2.AuthTestSpotipy) ... ok test_recommendations (test_auth2.AuthTestSpotipy) ... ok test_request_with_token (test_client_credentials.ClientCredentialsTestSpotipy) ... ok test_badly_scoped_token_bails (test_oauth.OAuthCacheTest) ... ok test_expired_token_refreshes (test_oauth.OAuthCacheTest) ... ok test_gets_from_cache_path (test_oauth.OAuthCacheTest) ... ok test_saves_to_cache_path (test_oauth.OAuthCacheTest) ... ok test_get_authorize_url_does_not_show_dialog_by_default (test_oauth.TestSpotifyOAuth) ... ok test_get_authorize_url_doesnt_pass_state_by_default (test_oauth.TestSpotifyOAuth) ... ok test_get_authorize_url_passes_state_from_constructor (test_oauth.TestSpotifyOAuth) ... ok test_get_authorize_url_passes_state_from_func_call (test_oauth.TestSpotifyOAuth) ... ok test_get_authorize_url_shows_dialog_when_requested (test_oauth.TestSpotifyOAuth) ... ok test_album_search (tests.TestSpotipy) ... ok test_album_tracks (tests.TestSpotipy) ... ok test_album_tracks_many (tests.TestSpotipy) ... ok test_album_urn (tests.TestSpotipy) ... ok test_albums (tests.TestSpotipy) ... ok test_artist_albums (tests.TestSpotipy) ... ok test_artist_related_artists (tests.TestSpotipy) ... ok test_artist_search (tests.TestSpotipy) ... ok test_artist_search_with_market (tests.TestSpotipy) ... ok test_artist_top_tracks (tests.TestSpotipy) ... ok test_artist_urn (tests.TestSpotipy) ... ok test_artists (tests.TestSpotipy) ... ok test_custom_requests_session (tests.TestSpotipy) ... ok test_force_no_requests_session (tests.TestSpotipy) ... ok test_search_timeout (tests.TestSpotipy) ... ok test_track_bad_id (tests.TestSpotipy) ... ok test_track_bad_urn (tests.TestSpotipy) ... ok test_track_id (tests.TestSpotipy) ... ok test_track_search (tests.TestSpotipy) ... ok test_track_url (tests.TestSpotipy) ... ok test_track_urn (tests.TestSpotipy) ... ok test_tracks (tests.TestSpotipy) ... ok test_unauthenticated_post_fails (tests.TestSpotipy) ... ok test_user (tests.TestSpotipy) ... ok ---------------------------------------------------------------------- Ran 60 tests in 69.277s OK ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:02:21 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
feature/2026-02-changes
feature/invalid-uri-warning
feature/refresh-endpoints
doc-deprecations
revert-synchronize
v3
run-tests
bugfix/1149-change-cache-name
2.23.0
v3_oldprsonly
2.26.0
2.25.2
2.25.1
2.25.0
2.24.0
2.23.0
2.22.1
2.22.0
2.21.0
2.20.0
2.19.0
2.18.0
2.17.1
2.17.0
2.16.1
2.16.0
2.15.0
2.14.0
2.13.0
2.12.0
2.11.2
2.11.1
2.11.0
2.10.0
2.9.0
2.8.0
2.7.1
2.7.0
2.6.3
2.6.2
2.6.1
2.6.0
2.5.0
Labels
Clear labels   
api-bug

   
bug

   
dependencies

   
documentation

   
duplicate

   
enhancement

   
external-ide

   
headless-mode

   
implicit-grant-flow

   
invalid

   
missing-endpoint

   
pr-welcome

   
private-api

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
spotipy3

   
wontfix
No labels
api-bug
bug
dependencies
documentation
duplicate
enhancement
external-ide
headless-mode
implicit-grant-flow
invalid
missing-endpoint
pr-welcome
private-api
pull-request
question
spotipy3
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotipy#883
No description provided.