[PR #392] [MERGED] requests_cache compatibility #878

Closed
opened 2026-02-28 00:02:19 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/spotipy-dev/spotipy/pull/392
Author: @TimJay
Created: 7/27/2019
Status: Merged
Merged: 1/12/2020
Merged by: @stephanebruckert

Base: masterHead: master


📝 Commits (1)

  • 2252ea5 requests_cache compatibility

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 spotipy/client.py (+2 -1)

📄 Description

When using requests_cache, the cached request does not have a connection attribute. Explicitly checking for it before closing the connection enables use of requests_cache.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/spotipy-dev/spotipy/pull/392 **Author:** [@TimJay](https://github.com/TimJay) **Created:** 7/27/2019 **Status:** ✅ Merged **Merged:** 1/12/2020 **Merged by:** [@stephanebruckert](https://github.com/stephanebruckert) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`2252ea5`](https://github.com/spotipy-dev/spotipy/commit/2252ea5cfa6b55903d1152c2fa159351b8f43415) requests_cache compatibility ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `spotipy/client.py` (+2 -1) </details> ### 📄 Description When using [requests_cache](https://github.com/reclosedev/requests-cache), the cached request does not have a _connection_ attribute. Explicitly checking for it before closing the connection enables use of _requests_cache_. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:02:19 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotipy#878
No description provided.