[PR #185] [MERGED] Changes critical is not for != #807

Closed
opened 2026-02-28 00:01:51 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/spotipy-dev/spotipy/pull/185
Author: @ncordon
Created: 4/14/2017
Status: Merged
Merged: 9/17/2017
Merged by: @plamere

Base: masterHead: patch-1


📝 Commits (1)

  • 5171911 Changes critical is not for !=

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 spotipy/oauth2.py (+2 -2)

📄 Description

Hi, I was having trouble deploying an application in AppEngine using spotipy Client Credentials Flow. After a lot of debugging, I've realized there's two critical comparisons to a response status 200 made with is not, when they should be made with != since they're comparisons against a number.

Regards


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/spotipy-dev/spotipy/pull/185 **Author:** [@ncordon](https://github.com/ncordon) **Created:** 4/14/2017 **Status:** ✅ Merged **Merged:** 9/17/2017 **Merged by:** [@plamere](https://github.com/plamere) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`5171911`](https://github.com/spotipy-dev/spotipy/commit/5171911342a11882ddff93db006c05c7a3f3075f) Changes critical is not for != ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `spotipy/oauth2.py` (+2 -2) </details> ### 📄 Description Hi, I was having trouble deploying an application in AppEngine using `spotipy` Client Credentials Flow. After a lot of debugging, I've realized there's two critical comparisons to a response status 200 made with `is not`, when they should be made with `!=` since they're comparisons against a number. Regards --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:01:51 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotipy#807
No description provided.