[PR #25] [CLOSED] Travis CI fixup #730

New issue

Closed

opened 2026-02-28 00:01:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:01:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/spotipy-dev/spotipy/pull/25
Author: @hugovk
Created: 9/8/2014
Status: ❌ Closed

Base: master ← Head: travis

📝 Commits (6)

7a8f129 Fix prints for Python 3 (+flake8)
e8d9295 Print name of example before running it.
a24ceb2 Change example to run on long_track_test.dat if no input file specified so as not to time-out and error Travis CI
bfa9973 Add pypy3 and allow all Py3 to fail
25be32b Add Travis build badge
2272e6e Merge branch 'master' into travis

📊 Changes

22 files changed (+51 additions, -31 deletions)

View changed files

📝 .travis.yml (+4 -1)
📝 README.md (+2 -0)
📝 examples/add_a_saved_track.py (+1 -0)
📝 examples/add_tracks_to_playlist.py (+1 -1)
📝 examples/artist_discography.py (+5 -1)
📝 examples/contains_a_saved_track.py (+1 -0)
📝 examples/create_playlist.py (+1 -0)
📝 examples/delete_a_saved_track.py (+1 -0)
📝 examples/remove_specific_tracks_from_playlist.py (+5 -2)
📝 examples/remove_tracks_from_playlist.py (+4 -1)
📝 examples/replace_tracks_in_playlist.py (+1 -0)
📝 examples/show_artist_top_tracks.py (+1 -1)
📝 examples/show_my_saved_tracks.py (+1 -0)
📝 examples/show_related.py (+1 -2)
📝 examples/show_tracks.py (+2 -4)
📝 examples/simple0.py (+1 -0)
📝 examples/simple2.py (+1 -2)
📝 examples/simple3.py (+1 -1)
📝 examples/user_playlists.py (+1 -3)
📝 examples/user_playlists_contents.py (+6 -4)

...and 2 more files

📄 Description

The Travis CI builds were failing.

The example show_tracks.py was timing out because it was waiting for some stdin which never appeared. I changed the default, when no parameters are given, to use the example long_track_test.dat
Python 3 was failing in many places because it used Python 2-style prints. Updated to use from __future__ import print_function so the same Python 3-style print()s work on both Py2 and Py3.
Python 3 is still failing because it doesn't like the import in __init__.py, but I've allowed Python 3 builds to fail for the time being (allow_failures in .travis.yml).
Added a Travis CI build badge to the README so broken code can be discovered sooner.
flake8 for the modified files.

Please can you enable Travis CI and Coveralls for your account?

Both are free, you log in with your GitHub ID:

Also, pull requests will be built so you can see the status before merging in.

Thanks!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/spotipy-dev/spotipy/pull/25 **Author:** [@hugovk](https://github.com/hugovk) **Created:** 9/8/2014 **Status:** ❌ Closed **Base:** `master` ← **Head:** `travis` --- ### 📝 Commits (6) - [`7a8f129`](https://github.com/spotipy-dev/spotipy/commit/7a8f12942c95f6ad848a86dda4769ac9607438d1) Fix prints for Python 3 (+flake8) - [`e8d9295`](https://github.com/spotipy-dev/spotipy/commit/e8d9295d241eafc3794f9fc6c2f8366f25f2bb1c) Print name of example before running it. - [`a24ceb2`](https://github.com/spotipy-dev/spotipy/commit/a24ceb263f522a7f395d69c4e306fc56ac00b6ec) Change example to run on long_track_test.dat if no input file specified so as not to time-out and error Travis CI - [`bfa9973`](https://github.com/spotipy-dev/spotipy/commit/bfa997334418ee66f63ab1d439e6c500a15dafec) Add pypy3 and allow all Py3 to fail - [`25be32b`](https://github.com/spotipy-dev/spotipy/commit/25be32b88a98a0349b00641d3f6474c32d58c025) Add Travis build badge - [`2272e6e`](https://github.com/spotipy-dev/spotipy/commit/2272e6e0507b6f805e2cdcf91d2a3e2e10a3c7a3) Merge branch 'master' into travis ### 📊 Changes **22 files changed** (+51 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+4 -1) 📝 `README.md` (+2 -0) 📝 `examples/add_a_saved_track.py` (+1 -0) 📝 `examples/add_tracks_to_playlist.py` (+1 -1) 📝 `examples/artist_discography.py` (+5 -1) 📝 `examples/contains_a_saved_track.py` (+1 -0) 📝 `examples/create_playlist.py` (+1 -0) 📝 `examples/delete_a_saved_track.py` (+1 -0) 📝 `examples/remove_specific_tracks_from_playlist.py` (+5 -2) 📝 `examples/remove_tracks_from_playlist.py` (+4 -1) 📝 `examples/replace_tracks_in_playlist.py` (+1 -0) 📝 `examples/show_artist_top_tracks.py` (+1 -1) 📝 `examples/show_my_saved_tracks.py` (+1 -0) 📝 `examples/show_related.py` (+1 -2) 📝 `examples/show_tracks.py` (+2 -4) 📝 `examples/simple0.py` (+1 -0) 📝 `examples/simple2.py` (+1 -2) 📝 `examples/simple3.py` (+1 -1) 📝 `examples/user_playlists.py` (+1 -3) 📝 `examples/user_playlists_contents.py` (+6 -4) _...and 2 more files_ </details> ### 📄 Description The Travis CI builds were failing. - The example show_tracks.py was timing out because it was waiting for some stdin which never appeared. I changed the default, when no parameters are given, to use the example long_track_test.dat - Python 3 was failing in many places because it used Python 2-style prints. Updated to use `from __future__ import print_function` so the same Python 3-style `print()`s work on both Py2 and Py3. - Python 3 is still failing because it doesn't like the import in `__init__.py`, but I've allowed Python 3 builds to fail for the time being (`allow_failures` in .travis.yml). - Added a Travis CI build badge to the README so broken code can be discovered sooner. - `flake8` for the modified files. Please can you enable Travis CI and Coveralls for your account? Both are free, you log in with your GitHub ID: - https://travis-ci.org/profile/ - https://coveralls.io/repos/new Also, pull requests will be built so you can see the status before merging in. Thanks! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>