[GH-ISSUE #1154] Move linting/code style checks to a separate test #677

New issue

Closed

opened 2026-02-28 00:00:46 +03:00 by kerem · 2 comments

kerem commented

2026-02-28 00:00:46 +03:00

Owner

Originally created by @JackDyre on GitHub (Aug 9, 2024).
Original GitHub issue: https://github.com/spotipy-dev/spotipy/issues/1154

I would be nice if the linting/code style tests were in their own test. It is kinda confusing when I make a change and all the tests fail, but it is only because I forgot to run the linting commands and the all of the tests passed.

Originally created by @JackDyre on GitHub (Aug 9, 2024). Original GitHub issue: https://github.com/spotipy-dev/spotipy/issues/1154 I would be nice if the linting/code style tests were in their own test. It is kinda confusing when I make a change and all the tests fail, but it is only because I forgot to run the linting commands and the all of the tests passed.

kerem

2026-02-28 00:00:46 +03:00

closed this issue
added the
enhancement
label

kerem commented

2026-02-28 00:00:47 +03:00

Author

Owner

@stephanebruckert commented on GitHub (Aug 10, 2024):

We could split linting/testing into different workflows so it shows more clearly what's green or red. ~~Also we could only run the linting step or workflow when the PR is not a draft?~~ (actually a bad idea, someone might want to focus mostly on linting)

On your side you could also look at setting up flake8 in your code editor so it fixes code automatically.

@stephanebruckert commented on GitHub (Aug 10, 2024): We could split linting/testing into different workflows so it shows more clearly what's green or red. ~~Also we could only run the linting step or workflow when the PR is not a draft?~~ (actually a bad idea, someone might want to focus mostly on linting) On your side you could also look at setting up flake8 in your code editor so it fixes code automatically.

kerem commented

2026-02-28 00:00:47 +03:00

Author

Owner

@dieser-niko commented on GitHub (Aug 12, 2024):

While we're at it, we might want to remove the line pip install -Iv enum34==1.1.6, as we don't support versions below 3.4 anyway.

@dieser-niko commented on GitHub (Aug 12, 2024): While we're at it, we might want to remove the line `pip install -Iv enum34==1.1.6`, as we don't support versions below 3.4 anyway.