mirror of
https://github.com/spotipy-dev/spotipy.git
synced 2026-04-26 08:05:55 +03:00
[GH-ISSUE #1149] Invalidate cache if the credentials change (or the credentials become invalid) #676
Labels
No labels
api-bug
bug
dependencies
documentation
duplicate
enhancement
external-ide
headless-mode
implicit-grant-flow
invalid
missing-endpoint
pr-welcome
private-api
pull-request
question
spotipy3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotipy#676
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @vitorbaptista on GitHub (Jul 25, 2024).
Original GitHub issue: https://github.com/spotipy-dev/spotipy/issues/1149
Originally assigned to: @dieser-niko on GitHub.
Is your feature request related to a problem? Please describe.
Spotify blocked one of my API keys. I noticed this when I was running a simple Spotipy example (just searching an artist name), and Spotipy failed after retrying 3 times. I changed the credentials on my Spotipy script, but the failure was the same. After ~2 hours of debugging, I realized that Spotipy was using the
.cachewith the old key so, after deleting this file, it used my new key and everything worked.Describe the solution you'd like
I see two potential solutions:
Describe alternatives you've considered
It wasn't clear that the issue was with my credentials. I just ran Spotipy and it took a while to run (because it was retrying 3x), and then failed with a 429 Too Many Requests error. A clearer error message would have made my life easier.
@dieser-niko commented on GitHub (Jul 26, 2024):
Your first potential solution would be effective and quite simple to implement. While reading up to this point, I was thinking of something similar.
I'll start working on a new CacheHandler, this shouldn't be too hard.
@dieser-niko commented on GitHub (Jul 26, 2024):
So currently there's something similar, but for usernames. Basically the username is appended to the end of the filename.
I'll probably go down a similar route, but reduce the hash length to 7 chars.
I also thought about hijacking the username parameter as it's marked as deprecated, but that just feels wrong if this is supposed to be official :)
@dieser-niko commented on GitHub (Jul 30, 2024):
After some internal discussions with @stephanebruckert, we came to the conclusion that this change should be kept for the v3 release, as it would be somewhat difficult and unstable to implement a solution that is also backwards compatible. Also, this problem does not only affect the
CacheFileHandler, but pretty much any other cache handler that has some kind of name attribute.@vitinhohhh commented on GitHub (Mar 9, 2025):
https://github.com/spotipy-dev/spotipy/issues/1149#issue-2430410583